From: Tom Tromey <tom@tromey.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, btrace: fix error diagnostics
Date: Fri, 08 Mar 2024 09:21:50 -0700 [thread overview]
Message-ID: <877cicsnhd.fsf@tromey.com> (raw)
In-Reply-To: <20240307150110.3348612-1-markus.t.metzger@intel.com> (Markus Metzger's message of "Thu, 7 Mar 2024 15:01:10 +0000")
>>>>> Markus Metzger <markus.t.metzger@intel.com> writes:
> When we improved error messages in
> cd393cec3ab gdb, btrace: improve error messages
> we cleared the original errno. When the error reason can not be explained
> in a more detailed error message, and we fall back to the default error
> message, it now gives Success as error.
> Restore the original errno to fix that.
Thank you. This looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2024-03-08 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 15:01 Markus Metzger
2024-03-08 9:07 ` Guinevere Larsen
2024-03-08 16:21 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cicsnhd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).