From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3F93A386186C for ; Fri, 15 Dec 2023 11:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F93A386186C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3F93A386186C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702638110; cv=none; b=hcewxTpejD3uJ1QJ3v5QNxzq9ZncfwmZTAczCUHgiJjIDulwd1KpwD4wfmSRa82gRlaP/uB0m05bk6k1/7SAQzA/qXA4+z2xY8MiMFCcHoZkbHwTYSDuBYLG8d+XMYzw7IwP3ab85OvwQWM7J3uJy0HlmJoM2IselstT6lViLDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702638110; c=relaxed/simple; bh=TCrMsR1hLslcyQmbVZNuwL9cl3PpMDsMYGpF84wL1FI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=I6EUkofQASarwLTL72lcsJrwEDqnG4sSK8T/FJIx620O4TEC3Q48gQk5V0MA+eZM2Dt8nIFt4tU8tPXC0WxKRloRZPDFxdxzG0AggjFYbndBr5espe+O0updYQHcr5AcFl3AoRVR/6dq1J7XQcLFQ3wK/UizlNWePqYtxhBq1cw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702638103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F/1x8NUP/tpNGsTNw1dyGrGIpM7CS5OcWHe9wZGE/Ko=; b=Xh1/1o2jHD1EL6xTblN19ubQTTJB5HRj+tZdptvmzpUBqAnqUgCKcSsHfLO1MeqE2mMv+D f1U1ndnxm2f7VLTDPvWXXbOxnYR1KhNtgludirHFgsarLEoJeARxMaOMGbEtk0rrBKtT/F dzd/8uhrNHPkC+HYvmncmbQshdf0P8c= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-1gLouU6qNPKidZS5qvPE3Q-1; Fri, 15 Dec 2023 06:01:41 -0500 X-MC-Unique: 1gLouU6qNPKidZS5qvPE3Q-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-77f37b228eeso86406885a.1 for ; Fri, 15 Dec 2023 03:01:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702638101; x=1703242901; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iqYxEW+xcyu2vgOMxP/aH0kZGKB0b63Gah//mHs5eJA=; b=iBCJDhfSmr1LUFRJ+ji+ENag8xS+iy73YKUL5HBLagCJyxY43iAb6VsvC0dvmrm+9S q3W+s3fAok8HCK4cWkNdCBkHoYtO+s6LCIyqATMjOoAid9zVFsEANDrgLJFoEOVOIqHt hV1HbaDaFZmcpGjjFt8HTj+OBSQKmmK1HsXRSTx4QfFGxIZ59YMEWTvuG3wnPID4KB8V R+fEhMJNzjNfhzM/QUn7QwVogIMji/yQlIFP3otCbrNrJfmz63m9107WAq8agzjlGeBn iVWo+0R+7wRyBt3Mjh7t0uhkI6HNDxhU75T4bG1lNXfLCNa/Zqt6JSUrrCE03ZE8r2tp Hd3g== X-Gm-Message-State: AOJu0Yw0cn0xfWYTu8uLck9YDyvNgi9gSTRsZvKppphJdrpkN1KFyWR9 zdIC9Y/2RA+tVbBlGo25Rsu49enJoJFJ18wuOg2bQsQQRoTJP/IKIwUSfnwqkQ0NleLyPgUfL8n HljFTH/y7RB1kC5uNkXGC2g== X-Received: by 2002:a05:620a:10a8:b0:77d:6baf:52b8 with SMTP id h8-20020a05620a10a800b0077d6baf52b8mr11862527qkk.64.1702638100769; Fri, 15 Dec 2023 03:01:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8QSt6UITJUal+ZQnbP1on+kqYG0uFcvgPQo091IfwXStGEH7EzZirV6q6EB5eLTbzUqb02A== X-Received: by 2002:a05:620a:10a8:b0:77d:6baf:52b8 with SMTP id h8-20020a05620a10a800b0077d6baf52b8mr11862518qkk.64.1702638100495; Fri, 15 Dec 2023 03:01:40 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id l3-20020ae9f003000000b0077f9596eecasm1864574qkg.34.2023.12.15.03.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 03:01:40 -0800 (PST) From: Andrew Burgess To: Mike Frysinger , gdb-patches@sourceware.org Subject: Re: [PATCH] sim: igen: do not reindent literal semantics output In-Reply-To: <20231215033634.15724-1-vapier@gentoo.org> References: <20231215033634.15724-1-vapier@gentoo.org> Date: Fri, 15 Dec 2023 11:01:38 +0000 Message-ID: <877clf686l.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Mike Frysinger writes: > When generating semantics.c from .igen source files, indenting the code > makes it more readable, but confuses compiler diagnostics. The latter > is a bit more important than the former, so bias towards that. > > For example, with an introduced error, we can see w/gcc-13: Makes sense. Reviewed-By: Andrew Burgess Thanks, Andrew > > (before this change) > CC mn10300/semantics.o > ../../../sim/mn10300/am33-2.igen: In function =E2=80=98semantic_dcpf_D1a= =E2=80=99: > ../../../sim/mn10300/am33-2.igen:11:5: error: =E2=80=98srcreg=E2=80=99 un= declared (first use in this function) > 11 | srcreg =3D translate_rreg (SD_, RN2); > | ^~~~~~ > > (with this change) > CC mn10300/semantics.o > ../../../sim/mn10300/am33-2.igen: In function =E2=80=98semantic_dcpf_D1a= =E2=80=99: > ../../../sim/mn10300/am33-2.igen:11:3: error: =E2=80=98srcreg=E2=80=99 un= declared (first use in this function) > 11 | srcreg =3D translate_rreg (SD_, RN2); > | ^~~~~~ > --- > sim/igen/gen-semantics.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/sim/igen/gen-semantics.c b/sim/igen/gen-semantics.c > index 54d83d61eccd..455702973e4b 100644 > --- a/sim/igen/gen-semantics.c > +++ b/sim/igen/gen-semantics.c > @@ -262,10 +262,17 @@ print_semantic_body (lf *file, > { > /* true code */ > lf_printf (file, "{\n"); > - lf_indent (file, +2); > + /* NB: Do not indent the code. If the .igen source files cause a = compiler > +=09 warning, the diagnostics can read the line from the original source, > +=09 but use column offsets from the generated files, causing columns to = be > +=09 misaligned. It makes the generated code slightly more difficult to > +=09 read, but accurate compiler diagnostics relative to the original sou= rce > +=09 are more important here. > + lf_indent (file, +2); */ > lf_print__line_ref (file, instruction->code->line); > table_print_code (file, instruction->code); > - lf_indent (file, -2); > + /* NB: Disabled -- see above. > + lf_indent (file, -2); */ > lf_printf (file, "}\n"); > lf_print__internal_ref (file); > } > --=20 > 2.43.0