From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/options: fix copy&paste error in string_option_def
Date: Thu, 14 Dec 2023 08:36:06 -0700 [thread overview]
Message-ID: <877clgaja1.fsf@tromey.com> (raw)
In-Reply-To: <7d5ab0d95447c98d8581a94c1e1568dd44ffdf34.1702559691.git.aburgess@redhat.com> (Andrew Burgess's message of "Thu, 14 Dec 2023 13:17:00 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Spotted what appears to be a copy&paste error in string_option_def,
Andrew> the code for string handling writes the address fetching callback
Andrew> function into the option_def::var_address::enumeration location,
Andrew> rather than option_def::var_address::string.
Andrew> Of course, this works just fine as option_def::var_address is a union,
Andrew> and all of its members are function pointers, so they're going to be
Andrew> the same size on every target GDB cares about.
Andrew> But it doesn't hurt to be correct, so fixed in this commit.
Looks good. Thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-12-14 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 13:17 Andrew Burgess
2023-12-14 15:36 ` Tom Tromey [this message]
2023-12-14 16:29 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877clgaja1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).