From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id EE9583858407 for ; Mon, 11 Dec 2023 20:26:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE9583858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE9583858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702326376; cv=none; b=V9e0ynTcK2ByiksoLa7m0qpDLhpYzlMiLMAQuaVPmPma1xSF4xfcFN/u9XydbWNs6zj8kQpo9TEMmtpbPS2z8UnzB2gSflxFe8LjIBXkuWPlvQM0XvqQt0xaLYCLlZ6pcThEkt1wKojLIdu/WUGoZPQ37fweRvueOwox2RI13ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702326376; c=relaxed/simple; bh=KgfiECurK6C9rf2l2toVx5dcir2u6P5L0hO00t8ir3I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IpjMOY6vTJ3Mw2iNDGoIa/Pjj1KKT178I6Ez5yHTZas40QQz65+5yUqv/hkLIeUORWPvWpw70qXfiRqjKO0KG3MRvanE7cWKcp/ac+uaLKklU+7fnRhmc3ckYgCA6CwUe3GAgQd0N6sxlD0lmpa4tM1f14/wkr1ktfcvb6tpy9E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id Cl8Or9MIJ8HteCmqzrImQS; Mon, 11 Dec 2023 20:26:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id CmqyrUeYpb8QnCmqyrta0n; Mon, 11 Dec 2023 20:26:13 +0000 X-Authority-Analysis: v=2.4 cv=IuQNzZzg c=1 sm=1 tr=0 ts=65777065 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=_g_lDDes6adhAX7u3lUA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KgfiECurK6C9rf2l2toVx5dcir2u6P5L0hO00t8ir3I=; b=ry1H+SP3vIahHqbhQBRUlI3B9F CMk1ynVyJXQ3AOEGklJFj+37zC57debM9CObEo+Z2OeDTWIsM2L+ch+jigGSH+epi9WtiRw5cor1i 437B+rJWyebdcSxBZ83G7EVzN; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:49658 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rCmqy-003J5W-11; Mon, 11 Dec 2023 13:26:12 -0700 From: Tom Tromey To: Hannes Domani Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.FinishBreakpoint when returning to an inlined function References: <20231211181438.2851-1-ssbssa.ref@yahoo.de> <20231211181438.2851-1-ssbssa@yahoo.de> X-Attribution: Tom Date: Mon, 11 Dec 2023 13:26:11 -0700 In-Reply-To: <20231211181438.2851-1-ssbssa@yahoo.de> (Hannes Domani's message of "Mon, 11 Dec 2023 19:14:38 +0100") Message-ID: <877clkeba4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rCmqy-003J5W-11 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:49658 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIzOOKbl8cnyMa7N6BZ6vWySc3+H0upX/VHpI8qUT/caSWRZajg1vCUufTFMsCYEIU8RS0R/D4aNYrxXVDAPgHHybYyLy74uoWA4xAxqTc9pXSaZRxBk HiAc83V4Sd2/8ftWC/AG9Tf22P3FyGKFcgMlw3uEWQAvmeH2ri27XZJ50KrUNPYviPkXPwC8EcE1n2WCKeInalewodCB3AVe2Nw= X-Spam-Status: No, score=-3017.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Hannes" == Hannes Domani writes: Hannes> Currently, when creating a gdb.FinishBreakpoint in a function Hannes> called from an inline frame, it will never be hit: Hannes> ``` Hannes> (gdb) py fb=gdb.FinishBreakpoint() Hannes> Temporary breakpoint 1 at 0x13f1917b4: file C:/src/repos/binutils-gdb.git/gdb/testsuite/gdb.python/py-finish-breakpoint.c, line 47. Hannes> (gdb) c Hannes> Continuing. Hannes> Thread-specific breakpoint 1 deleted - thread 1 no longer in the thread list. Hannes> [Inferior 1 (process 1208) exited normally] Hannes> ``` Hannes> The reason is that the frame_id of a breakpoint has to be the Hannes> ID of a real frame, ignoring any inline frames. Hannes> With this fixed, it's working correctly: Thank you, I think this is ok. Approved-By: Tom Tromey Tom