public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Luis Machado <luis.machado@arm.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] Fix "finish" for vector types on ARM
Date: Fri, 27 Oct 2023 11:42:05 -0600	[thread overview]
Message-ID: <877cn8m07m.fsf@tromey.com> (raw)
In-Reply-To: <4be8456e-7eeb-4ff7-9d5b-07d1fabd0216@arm.com> (Luis Machado's message of "Mon, 23 Oct 2023 15:03:20 +0100")

>>>>> "Luis" == Luis Machado <luis.machado@arm.com> writes:

>> I tested this using the AdaCore internal test suite; the test case
>> that caught this is identical to gdb.base/gnu_vector.exp.

Luis> Unfortunately I'm not sure passing vector types around is exercised by the testsuite, in
Luis> particular for ARM.

Luis> Do you have an example test where this is failing? I'd like to make sure things still
Luis> work for non-BE ARM.

The test code itself in the AdaCore test suite is pretty much identical
to gdb's gnu_vector.exp.  I don't know if that can run on ARM or not --
but if not, it should be fixed, because it runs fine internally.

Could you try that?

FWIW, AdaCore is also doing little-endian ARM testing.

Tom

  reply	other threads:[~2023-10-27 17:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 19:15 [PATCH 0/5] ARM function-calling / return fixes Tom Tromey
2023-10-20 19:15 ` [PATCH 1/5] Fix calls with small integers on ARM Tom Tromey
2023-10-23 13:14   ` Luis Machado
2023-10-27 18:08     ` Tom Tromey
2023-10-30  9:38       ` Luis Machado
2023-10-20 19:15 ` [PATCH 2/5] Fix "finish" with range types " Tom Tromey
2023-10-23 13:14   ` Luis Machado
2023-10-20 19:15 ` [PATCH 3/5] Fix "finish" for vector " Tom Tromey
2023-10-23 14:03   ` Luis Machado
2023-10-27 17:42     ` Tom Tromey [this message]
2023-10-30  9:36       ` Luis Machado
2023-10-30 13:44         ` Tom Tromey
2023-10-30 13:53           ` Luis Machado
2023-10-20 19:15 ` [PATCH 4/5] Fix range-type "return" command " Tom Tromey
2023-10-23 13:15   ` Luis Machado
2023-10-20 19:15 ` [PATCH 5/5] Fix fixed-point "return" " Tom Tromey
2023-10-23 13:16   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cn8m07m.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).