From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 8C6D53858D20 for ; Fri, 20 Oct 2023 17:50:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C6D53858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C6D53858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697824214; cv=none; b=rhEqlHz2d0lkc3CGEjEG3YI0vi8hsSud1fIRsuipaAle1mwHG4rU+gZCi8D0THzmbqklgAWMML8HYcm9aYzQsaSqGWqCZ+83mEiQrzO5jRw7KmMsLmnN+VkQ52d3un17YZ4vGlXdJ6D5ZkZ3f0qSB5R/Sd6YZMWEQDrlUdsSgnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697824214; c=relaxed/simple; bh=Ywv/LEHxak+FcY15OF5g8oGk7KplnMtRkoBS7DwxSIo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c19dBdSRAttTOReev19n4oAc+1fhs37NggO7P10Tg0+UTDhtR40Hlng51lmb72k+9HCkTgRugQ+VhNZUPh953cHel0jcvch0+uQukXUXH8SSiC5WEL/SD0vCAPWc9Jdn41y0LstzL5Vwa6fGlJLxG1QNi8Xmc2kKAAJpT0W4KiE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id tZAdqOcB8WcCIttdUqOZQZ; Fri, 20 Oct 2023 17:50:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ttdSqzyrtRqxCttdTqPjPh; Fri, 20 Oct 2023 17:50:11 +0000 X-Authority-Analysis: v=2.4 cv=IY2U5Ema c=1 sm=1 tr=0 ts=6532bdd3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=lOM2l8M_QGUMBswx_SkA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=72+XjN2oRGvunjy7EsBSjfZEc1ZyjsFoTWbeXmB/9os=; b=yfEyuRl4Jy29nyC3Zvp21BIzDZ dSMilE8eDx2u3wXtzQ5lUJxKIH/jWj7pdFircXwH/TCITI9Kekt0puq4yIhgRKy0DuTDu8ykSEkxH va5IEHq9orsfrJdbIwwFoY5O2; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:45072 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qttdS-001Gag-1X; Fri, 20 Oct 2023 11:50:10 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] gdb: refactor objfile::find_and_add_separate_symbol_file References: <108c51107d11eae41fd77d54d73613569875c4c7.1697626088.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 20 Oct 2023 11:50:09 -0600 In-Reply-To: <108c51107d11eae41fd77d54d73613569875c4c7.1697626088.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 18 Oct 2023 11:53:21 +0100") Message-ID: <877cnhp4j2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qttdS-001Gag-1X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:45072 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOpObFnNbqRo8Ui7tqgsmDhEPQIJ6NNfkpxa8LvInUHSjzaRTXdQN+Ywejqsl8gd8fYBDthpeUgfUkOO4h+tPlhPruyN9vmb1SdQkh84oxHFD2VS6Jop hTVPWotG91lL/V+A5X1EU7BOQMq+PLUmwD6Eshz6Uep01j/T3f0nQX2PYKQZHboN9GuRsu3M2bMxIHHTSJyDmoNT8mGVsqwvEyU= X-Spam-Status: No, score=-3017.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> This is purely a refactoring commit. Andrew> This commit splits objfile::find_and_add_separate_symbol_file into Andrew> some separate helper functions. My hope is that the steps for looking Andrew> up separate debug information are now clearer. Andrew> In a later commit I'm going to extend Andrew> objfile::find_and_add_separate_symbol_file, with some additional Andrew> logic, so starting with a simpler function will make the following Andrew> changes easier. Andrew> There should be no user visible changes after this commit. Andrew> +static std::pair Andrew> +simple_find_and_open_separate_symbol_file ... Andrew> + result = simple_find_and_open_separate_symbol_file Andrew> + (this, find_separate_debug_file_by_buildid, &warnings); ... Andrew> + if (result.first == nullptr) If this happens to go in after the C++17 series, this code could be cleaned up a little using structured bindings. Tom