From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta33.uswest2.a.cloudfilter.net (omta33.uswest2.a.cloudfilter.net [35.89.44.32]) by sourceware.org (Postfix) with ESMTPS id 5CAF13858D28 for ; Tue, 22 Aug 2023 18:49:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CAF13858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTP id YQUPqL5pMOzKlYWR6q74Di; Tue, 22 Aug 2023 18:49:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id YWR5qy4lNTpvbYWR5qyf1V; Tue, 22 Aug 2023 18:49:03 +0000 X-Authority-Analysis: v=2.4 cv=JcqvEGGV c=1 sm=1 tr=0 ts=64e5031f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=NsqxOMYwTHhd8eOVT10A:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9p+x4tOCUlSZP/W3thlzjg8nWUH1z5ptpI1d0W41ruA=; b=Jlh3hB6MXjBW2PAhDZzgy9YJgH FudasIm8NHwCIJiJUmXkzLsd5PD0Qh+gPXqBWdw+mpkZsru08gzazPHbw9psvHA3p15i2Hj5WOmIU mxfhWOJ3KKuJuK8gn7xtdqIPl; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:53208 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qYTaL-003ibb-1N; Tue, 22 Aug 2023 09:46:25 -0600 From: Tom Tromey To: Keith Seitz via Gdb-patches Cc: Keith Seitz Subject: Re: [PATCH] Verify COFF symbol stringtab offset References: <20230822152335.231921-1-keiths@redhat.com> X-Attribution: Tom Date: Tue, 22 Aug 2023 09:46:24 -0600 In-Reply-To: <20230822152335.231921-1-keiths@redhat.com> (Keith Seitz via Gdb-patches's message of "Tue, 22 Aug 2023 08:23:35 -0700") Message-ID: <877cpnw04v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qYTaL-003ibb-1N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:53208 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfK1f4CvXIdat1pPPc6/S7QofFbMMtgQ5Erw9UevnhQolvVrH5x/+jmONYcw4lxVTPC6Z7GZLxiDm+Php2nAleZBXDGsUS/+MAjJ9guUJePGZUk72/uPt rD2T/HhCBAxe3PA476SviTzdezM7i5AnSvSwHJQk+/yX9NQ6ivp8HIuL1L6nzSzIpTnq5bDi5+/vSt5nnJ7mkHADGyR8YyLlF7s= X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_BL,RCVD_IN_MSPIKE_L3,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Keith" == Keith Seitz via Gdb-patches writes: Keith> This patch addresses an issue with malformed/fuzzed debug information that Keith> was recently reported in gdb/30639. That bug specifically deals with Keith> an ASAN issue, but the reproducer provided by the reporter causes a Keith> another failure outside of ASAN: Thank you. Keith> Unfortunately, I haven't any idea how else to test this patch since Keith> COFF is not very common anymore. GCC removed support for it five Keith> years ago with GCC 8. If it is really that dead, then -- like stabs -- I'd like to remove it. These dead formats just make it harder to improve gdb while not providing value to any user. Actually with the advent of fuzzers, this code now has negative value, because it wastes time coming up with patches to fix bugs in code no one uses. Hmm, I should probably go reply on the stabs thread. Anyway, this is ok. Approved-By: Tom Tromey Tom