From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta33.uswest2.a.cloudfilter.net (omta33.uswest2.a.cloudfilter.net [35.89.44.32]) by sourceware.org (Postfix) with ESMTPS id 8B26D38515DB for ; Fri, 18 Aug 2023 15:46:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B26D38515DB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTP id WcMGqvqB7faVXX1gJqgXaL; Fri, 18 Aug 2023 15:46:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id X1gIqQcYqHSofX1gIqJZlj; Fri, 18 Aug 2023 15:46:34 +0000 X-Authority-Analysis: v=2.4 cv=HbEH8wI8 c=1 sm=1 tr=0 ts=64df925a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=mQ4OAHRySsxYKR-vTaYA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CHZpNiQ2Pd4oHA9o77ulUbnt2vM6TEiSGtQqgkZfa+c=; b=iqLkUG0AtOYsUPmb6mikNuDhVI 8TV9XRPMy7R0Z/xdULCTdPg509pon+k1b4Umw+NUSCk7N/SCWxjZXIjyWPIlhrP0pcgNuKt69cSmO 1ZXyttc6Xs/V9ooVOE8vT75/3; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:46748 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qX1gI-003KON-00; Fri, 18 Aug 2023 09:46:34 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH] [gdb/build] Work around cgen odr violations References: <20230818083857.15960-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 18 Aug 2023 09:46:33 -0600 In-Reply-To: <20230818083857.15960-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 18 Aug 2023 10:38:57 +0200") Message-ID: <877cpsxsiu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qX1gI-003KON-00 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:46748 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMOurmQb2gCFelcOSwRy2KcKMeHtj90bGtBNFB6GBo2wAxxnWYwGFi/IRLCaQM36YUH/8SinqClXL2zsEE7iBZo+ge+M52ce4C6INxFB9JSNCY1zzIx5 dkVuwkAT27MBDLhW0Zjj0RPOEhPZscpKbsI+hJrir3OdKb4l23bW4ULgoMUCWlU0G9cwZtS6RTGIn+rjyNpMqEyh6Ol9GddRGCI= X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_BL,RCVD_IN_MSPIKE_L3,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> When building gdb with -flto -O2, I run into: Tom> ... Tom> opcodes/mep-desc.h:250:14: warning: type 'cgen_operand_type' violates the \ Tom> C++ One Definition Rule [-Wodr] Tom> typedef enum cgen_operand_type { I thought... hey, the best way is probably to change cgen to emit different names for these things. So I tried looking at cgen. Then I found out I don't know how it can even be run at all. Maybe it requires the obsolete-and-no-longer-shipped Guile 1.8 -- it definitely barfs with newer versions. Tom> Fix this by making the conflicting type names unique, adding a target-specific Tom> prefix using a define before the include: Tom> ... Tom> #define cgen_operand_type _cgen_operand_type Tom> #define cgen_hw_type _cgen_hw_type Tom> #include "opcodes/-desc.h" Tom> ... Thanks. Approved-By: Tom Tromey Tom> A PR has been filed to take care of this in the opcodes dir instead (PR30758). That was WONTFIX'd unfortunately. Tom