From: Tom Tromey <tom@tromey.com>
To: Carl Love via Gdb-patches <gdb-patches@sourceware.org>
Cc: Ulrich.Weigand@de.ibm.com, Tom de Vries <tdevries@suse.de>,
Carl Love <cel@us.ibm.com>
Subject: Re: [PATCH] Fix gdb.ada/O2_float_param.exp for PowerPC
Date: Fri, 04 Aug 2023 10:05:34 -0600 [thread overview]
Message-ID: <877cqabxo1.fsf@tromey.com> (raw)
In-Reply-To: <8c268cb3c33f5cf94c12e467b973db607ff53d21.camel@us.ibm.com> (Carl Love via Gdb-patches's message of "Fri, 04 Aug 2023 08:21:32 -0700")
>>>>> "Carl" == Carl Love via Gdb-patches <gdb-patches@sourceware.org> writes:
Carl> Fix gdb.ada/O2_float_param.exp for PowerPC
Carl> The frame command on Power pc prints the address in hex between the
Carl> #0 and in calle.increment. For example
Carl> (gdb) frame
Carl> #0 0x0000000010010a88 in callee.increment (val=val@entry=99.0, msg=...)
Carl> at /home/.../gdb/testsuite/gdb.ada/O2_float_param/callee.adb:19
Carl> 19 procedure Increment (Val : in out Float; Msg: String) is
Carl> + # Note, on PowerPC the output line looks like:
Carl> + # #0 0x0000000010010a88 in callee.increment (val=val@entry=99.0, msg=...)
Carl> + # Not all architectures print the address.
I don't think this is architecture-dependent. Instead, something else
is going wrong here. Why exactly is it printing the address? The code
here looks like:
if (opts.addressprint)
if (!sal.symtab
|| frame_show_address (frame, sal)
|| print_what == LOC_AND_ADDRESS)
Could it maybe be different inlining decisions?
Maybe seeing which of those clauses is true would show the answer.
I don't mind working around differences like this by patching the tests,
but I would like the real cause to be known and put into the comment.
Tom
next prev parent reply other threads:[~2023-08-04 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 15:21 Carl Love
2023-08-04 16:05 ` Tom Tromey [this message]
2023-08-04 22:56 ` Carl Love
2023-08-10 16:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cqabxo1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).