From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 85B163858D1E for ; Wed, 2 Aug 2023 19:41:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85B163858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id B88FF1003B6C9 for ; Wed, 2 Aug 2023 19:41:17 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RHifqrOudlzgsRHifqzb3C; Wed, 02 Aug 2023 19:41:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=eIXWMFl1 c=1 sm=1 tr=0 ts=64cab15d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=wQceswl01Wx6JQzD9nUA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UfJ6E8RHv+fdhx2yK6fgYMJSqDVGLYy68eU5ZN9vA9Q=; b=v+3NpwCTYF8e4Wzuv47/Hzgwrc OXJpfqjIBbTkixBBXHrH2UMssqlHL764qFcWaIAQ2VxNQOORA/oM+tkXVyxvq3wHPtGyb+Nny5ft9 h8Vl1rGZr3yxn2V0xIXZrwq7y; Received: from 75-166-148-59.hlrn.qwest.net ([75.166.148.59]:44136 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qRHif-002RUW-1B; Wed, 02 Aug 2023 13:41:17 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH v2 6/6] [gdb/testsuite] Extend gdb.base/index-cache.exp References: <20230802095305.3668-1-tdevries@suse.de> <20230802095305.3668-7-tdevries@suse.de> X-Attribution: Tom Date: Wed, 02 Aug 2023 13:41:16 -0600 In-Reply-To: <20230802095305.3668-7-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 2 Aug 2023 11:53:05 +0200") Message-ID: <877cqddyg3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.148.59 X-Source-L: No X-Exim-ID: 1qRHif-002RUW-1B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-148-59.hlrn.qwest.net (murgatroyd) [75.166.148.59]:44136 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> The test-case gdb.base/index-cache.exp uses only one source file, which Tom> contains main. Tom> While doing "file $exec", in set_initial_language a symbol lookup of "main" is Tom> done, causing the symtab containing main to be expanded. Tom> Handling of main is special, and a future optimization may skip the lookup and Tom> expansion. Tom> Reliably exercise: Tom> - the lookup of main, expanding the symtab containing main, by doing Tom> "ptype main", and Tom> - the lookup of another symbol, expanding a symtab not containing main, by: Tom> - adding another source file containing function foo, and Tom> - doing "ptype foo". Thanks. Approved-By: Tom Tromey Tom> This triggered a segfault with target board native-extended-gdbserver, filed Tom> as PR symtab/30712, but that seems to be fixed by a previous commit in this Tom> series. I guess something here needs needs a "Bug:" trailer, it's fine by me if it is this patch. Tom