From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id B10973858CDA for ; Fri, 28 Jul 2023 13:10:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B10973858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 91BAE100482A1 for ; Fri, 28 Jul 2023 13:10:16 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id PNEWq9AQZNWjFPNEWqbMaK; Fri, 28 Jul 2023 13:10:16 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=duget3s4 c=1 sm=1 tr=0 ts=64c3be38 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5HG5GDccJN+nFz+CVR3K23BJBp8zfjONATWPC1Jeku8=; b=Do3R26ZikiqlNf6UiV3ap/luQh gtVMYHUzS6bm0nUPDnhq2XjrGVKfVLQ4mqAiLoEqB9aOhbAHDrNYtPuNIL5g6SH04KgvBH/SOCx3x PIb10pTKoqca9/tpPvN1wSzMq; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:42432 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qPNEW-002SPA-15; Fri, 28 Jul 2023 07:10:16 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 2/2] [gdb] Initialize main_thread_id earlier References: <20230728105945.13909-1-tdevries@suse.de> <20230728105945.13909-2-tdevries@suse.de> X-Attribution: Tom Date: Fri, 28 Jul 2023 07:10:15 -0600 In-Reply-To: <20230728105945.13909-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 28 Jul 2023 12:59:45 +0200") Message-ID: <877cqki3m0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qPNEW-002SPA-15 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:42432 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> I wrote a patch using is_main_thread (), and found it returning false in the Tom> main thread due to main_thread_id not being initialized yet. Tom> Initialization currently takes place in _initialize_run_on_main_thread, but Tom> that's too late for earlier uses. Tom> Fix this by also initializing on first use. I wonder if it's enough to have: static std::thread::id main_thread_id = std::this_thread::get_id (); Tom> +#if CXX_STD_THREAD Tom> +static void Tom> +initialize_main_thread_id (void) "(void)" is only needed for C, you can just write "()" here. Tom