Re: [PATCH 2/3] gdb/testsuite: add test for core file with a 0 pid

[Andrew Burgess <aburgess@redhat.com>]

Pedro Alves <pedro@palves.net> writes:

> Hi Andrew,
>
> I'm skimming the thread to catch up, and noticed this:
>
> On 2023-06-05 10:11, Andrew Burgess via Gdb-patches wrote:
>> +++ b/gdb/testsuite/gdb.arch/core-file-pid0.exp
>> @@ -0,0 +1,63 @@
>> +# This testcase is part of GDB, the GNU debugger.
>> +#
>> +# Copyright 2023 Free Software Foundation, Inc.
>> +#
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 2 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program; if not, write to the Free Software
>> +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
>> +
>
> Wrong license (GPLv2), and wrong header -- we haven't been using the snail
> mail FSF header in years.

Ooops.  Thanks for spotting this.

I pushed the patch below to correct this mistake.

Thanks,
Andrew

---

commit 7c632c2a696fb68e5575db1e2c934788a831e578
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Fri Jul 7 10:51:53 2023 +0100

    gdb/testsuite: fix license on recently added file
    
    The license header on a file I recently contributed was incorrect.
    The file was added in commit:
    
      commit 087969169836f802a09b1cd0502d2f22d7a8f7dc
      Date:   Tue May 23 11:25:21 2023 +0100
    
          gdb: handle core files with .reg/0 section names
    
    The problems were:
    
      - GPLv2 instead of GPLv3,
      - Use the FSF postal address rather than their URL.
    
    Nobody else has touched the file since I merged it, so I don't believe
    there are any problems with me changing the license, this commit does
    just that.

diff --git a/gdb/testsuite/gdb.arch/core-file-pid0.exp b/gdb/testsuite/gdb.arch/core-file-pid0.exp
index 6e91111b44b..56746cca567 100644
--- a/gdb/testsuite/gdb.arch/core-file-pid0.exp
+++ b/gdb/testsuite/gdb.arch/core-file-pid0.exp
@@ -4,7 +4,7 @@
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
+# the Free Software Foundation; either version 3 of the License, or
 # (at your option) any later version.
 #
 # This program is distributed in the hope that it will be useful,
@@ -13,8 +13,7 @@
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 # Some kernel core files have PID 0 (for the idle task), check that
 # GDB can handle such a core file.