From: Andrew Burgess <aburgess@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>,
Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>, Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.tui/wrap-line.exp
Date: Tue, 23 May 2023 10:34:46 +0100 [thread overview]
Message-ID: <877csz8k7d.fsf@redhat.com> (raw)
In-Reply-To: <87sfbqqctf.fsf@linux-m68k.org>
Andreas Schwab <schwab@linux-m68k.org> writes:
> On Mai 21 2023, Andrew Burgess via Gdb-patches wrote:
>
>> Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>>> PR testsuite/30458 reports the following FAIL:
>>> ...
>>> PASS: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap
>>> ^CQuit
>>> (gdb) WARNING: timeout in accept_gdb_output
>>> Screen Dump (size 50 columns x 24 rows, cursor at column 6, row 3):
>>> 0 Quit
>>> 1 (gdb) 7890123456789012345678901234567890123456789
>>> 2 W^CQuit
>>> 3 (gdb)
>>> ...
>>> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap
>>> ...
>>>
>>> The problem is that the regexp doesn't account for the ^C:
>>> ...
>>> gdb_assert { [Term::wait_for "^WQuit"] } "prompt after wrap"
>>> ...
>>>
>>> Fix this by updating the regexp, and likewise in another place in the
>>> test-case where we use ^C.
>>
>> Do we know why we sometimes manage to see '^C'?
>
> Isn't that printed by the kernel (N_TTY ldisc)?
Not sure what the last part means. There's for sure code in readline
which seems to be responsible for printing '^C' in some cases, so I
suspect the kernel doesn't always print this. Maybe this kernel echoing
is turned off in our situation?
Thanks,
Andrew
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
next prev parent reply other threads:[~2023-05-23 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 6:10 Tom de Vries
2023-05-19 10:12 ` Bruno Larsen
2023-05-21 8:51 ` Andrew Burgess
2023-05-21 9:00 ` Andreas Schwab
2023-05-23 9:34 ` Andrew Burgess [this message]
2023-05-21 16:48 ` Tom de Vries
2023-05-30 9:06 ` Tom de Vries
2023-05-30 10:12 ` Andrew Burgess
2023-05-30 13:45 ` Andrew Burgess
2023-05-31 15:49 ` Tom de Vries
2023-06-01 11:12 ` Andrew Burgess
2023-06-21 14:19 ` Tom de Vries
2023-06-21 14:24 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877csz8k7d.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).