From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy6-pub.mail.unifiedlayer.com (qproxy6-pub.mail.unifiedlayer.com [69.89.23.12]) by sourceware.org (Postfix) with ESMTPS id E44C03856DC7 for ; Mon, 15 May 2023 14:49:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E44C03856DC7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by qproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id F156C8032BFE for ; Mon, 15 May 2023 14:49:54 +0000 (UTC) Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 048F31004E50B for ; Mon, 15 May 2023 14:48:54 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id yZVNpQkOgV8I5yZVNp51f8; Mon, 15 May 2023 14:48:53 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Z80poFdA c=1 sm=1 tr=0 ts=64624655 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=CCpqsmhAAAAA:8 a=hP2XZuS0DThdmasiwr4A:9 a=zZCYzV9kfG8A:10:nop_mobile_phish_fin_urg a=4G6NA9xxw8l3yy4pmD5M:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FT7Nc2iAlyIYBRNprujpi+hEqrvKdk3SmJqKFbhm8AE=; b=kLt447f2KIWudDGl35VEGJP+Ny TeZa+6tx39z0TxCssFgFd7MWAqpnG2+qAQPe/wccMjWh8hZ3Lk3WpzieLn+WUYurxFPuDsp0YrvWU 1EBBEq2e/J32yGalVLTlBo3uE; Received: from 75-166-157-55.hlrn.qwest.net ([75.166.157.55]:57450 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pyZVN-004FKM-MH; Mon, 15 May 2023 08:48:53 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Correctly handle forward DIE references in scanner References: <20230501221057.2375790-1-tom@tromey.com> X-Attribution: Tom Date: Mon, 15 May 2023 08:48:53 -0600 In-Reply-To: <20230501221057.2375790-1-tom@tromey.com> (Tom Tromey's message of "Mon, 1 May 2023 16:10:57 -0600") Message-ID: <877ct93b1m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.157.55 X-Source-L: No X-Exim-ID: 1pyZVN-004FKM-MH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-157-55.hlrn.qwest.net (murgatroyd) [75.166.157.55]:57450 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> The cooked index scanner has special code to handle forward DIE Tom> references. However, a bug report lead to the discovery that this Tom> code does not work -- the "deferred_entry::spec_offset" field is Tom> written to but never used, i.e., the lookup is done using the wrong Tom> key. Tom> This patch fixes the bug and adds a regression test. Tom> The test in the bug itself used a thread_local variable, which Tom> provoked a failure at runtime. This test instead uses "maint print Tom> objfiles" and then inspects to ensure that the entry in question has a Tom> parent. This lets us avoid a clang dependency in the test. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30271 I'm going check this in on master and gdb-13 now. Tom