From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id D3BCD3858D20 for ; Fri, 5 May 2023 13:09:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D3BCD3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 68B1A10044F66 for ; Fri, 5 May 2023 13:09:04 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id uvBIp709YynvEuvBIpAO2Z; Fri, 05 May 2023 13:09:04 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=fp4Z2H0f c=1 sm=1 tr=0 ts=6454fff0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=SrEYeTeyAsr1xLGlxigA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ns6NcG8qeaTv+eq/8sJJ8JhWrbOkt1lvGBAoATRkxPY=; b=vtHzJc3y0bKOrTjnT4irLMZoQ9 McFzOJ55BIf6bRyAcuwuzQ3PW7kA5PWxa3Q5d603JJyCKUpNXQ3pjZ4rK0X39MLz1j8BTo+icVvNv dWiJG2qByB5/CtayUCQO4Azcw; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:38248 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1puvBI-0022h6-5F; Fri, 05 May 2023 07:09:04 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom Tromey , Tom de Vries Subject: Re: [RFC 2/3] [gdb/dap] Allow Content-Length on separate line References: <20230314130535.6369-1-tdevries@suse.de> <20230314130535.6369-3-tdevries@suse.de> <87ilf3ju98.fsf@tromey.com> X-Attribution: Tom Date: Fri, 05 May 2023 07:09:03 -0600 In-Reply-To: (Tom de Vries via Gdb-patches's message of "Tue, 14 Mar 2023 16:35:03 +0100") Message-ID: <877ctnsz68.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1puvBI-0022h6-5F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:38248 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Sorry about the delay in replying to this. Tom> What I'm proposing with this patch allows in addition: Tom> ... Tom> Content-Length: 119\r\n Tom> \r\n Tom> { "seq": , ... }\r\n Tom> Content-Length: 119\r\n Tom> \r\n Tom> { "seq": , ... } Tom> ... Tom> So the \r\n that terminates the header is still there. Tom> And the blank line (^\r\n) that separates header and content is still there. Tom> Whether this is still confirming DAP, I can't tell from the specification. Yeah, the text says: Since both the last header field and the overall header itself are each terminated with \r\n, and since the header is mandatory, the content part of a message is always preceded (and uniquely identified) by two \r\n sequences. which to me means that they didn't consider the possibility of a blank line as the first line of the header part. Oops. Tom> So, perhaps we want to enable this selectively, say with a setting Tom> dap-parse-strict, and perhaps have some "set dap-cmd-input gdb.in" Tom> that automatically sets dap-parse-strict to 0. I'd be fine with this. Tom