From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 4EC5A3858D28 for ; Thu, 4 May 2023 09:01:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EC5A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f18335a870so1472935e9.0 for ; Thu, 04 May 2023 02:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1683190884; x=1685782884; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=a3Q8gXyowWD48L+BODaLzlcFReiS/E1XyxFsNmMgkVo=; b=CtergdXIFr9YKhXQzirFmAYrEcHZadUmgezr4Hn8QUTcPB5XsvMBs80b2/dCJZddb1 PEptqo7/nZQJCLBBgpgBliD6f//lLYB2nfBi9wkMydZmRZSsrs/Cm31TAAD5cbhHzNkB kCCjhjmJkSI6szdiaDPF5jTZomAZzNkw9HkDjEjjSNwwMX44gxME2JJhMnlVh9NJ1Z// t4xTKxsx9v4C3OwnXQlWM1ZcT5gr4B1Qw0rjsjahzARRgj/UzF2k885r0jSuIEwv+4VZ VW/izic9YAmAAAwYDILEQaxFZU2egaZFBnLWmeWeez1QDYQvLvfJy+HvVy/tdpcVVQo8 ZOBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683190884; x=1685782884; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a3Q8gXyowWD48L+BODaLzlcFReiS/E1XyxFsNmMgkVo=; b=AAbTfr7e/UlcMRVMLx1/3MEUxDTzS6H7KB3G4+dGGtCkryLGKB2qGXtH6PswqtQk7D KDn3yN0iJ+j3J/d8NBWyPpSzIi2ugD5Xl8zREqdIkStgXup1F9z/LgHeXACUi7zWaysI J2eVFR6WFau8bp1U6MYn02rMJjZR6Xr77qOG0whjmsjQhFmSwIfME4+HudQq3ZHlQFOD fJRN1AzajZGhhq+9+WZu30YHiBpHh+PzQSXlsRndKTR/lF5Q8kiMPwyUEvrRMXBy1a6L kSCcoB4ntssUdnC2gat09at7JLaY4KoxFk/vsI4v50E/DY5uROJDw+hoYE2WUa3c3EA9 LTDQ== X-Gm-Message-State: AC+VfDzMW+B6s+oFsiFm7Ixz5IuopqYYOrgxiiU6GYyuTEsyD2sCKAOu oYu+jRlNAmkVf4liBoOLnnfot7sePcMdqcjzanMEGg== X-Google-Smtp-Source: ACHHUZ7EhRmKjl3JGsRE+ZKp/OTelsrhiaPTx5MrgJITUiwhyFC6k90e/cSuFzQWHPiPdEFihWba9w== X-Received: by 2002:a05:600c:24cd:b0:3f1:7006:e782 with SMTP id 13-20020a05600c24cd00b003f17006e782mr16594325wmu.25.1683190883764; Thu, 04 May 2023 02:01:23 -0700 (PDT) Received: from legouguec-Precision-7550 ([2a01:e0a:253:fe0:f0f1:6926:c0dc:e34d]) by smtp.gmail.com with ESMTPSA id m20-20020a7bce14000000b003f3195be0a0sm4209237wmc.31.2023.05.04.02.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 02:01:23 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Tom de Vries Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/build] Fix frame_list position in frame.c In-Reply-To: (Tom de Vries's message of "Wed, 3 May 2023 21:45:59 +0200") References: <20230503175826.4242-1-tdevries@suse.de> <7ccea69e-7cce-9016-06a4-e63b3bf16a17@polymtl.ca> Date: Thu, 04 May 2023 11:01:22 +0200 Message-ID: <877ctoii71.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom de Vries writes: > On 5/3/23 20:47, Simon Marchi wrote: > >> In any case, this LGTM, thanks for doing this. Seconded, thanks for getting rid of that if guard. I find the new state of affairs (everything defined in the same unit, in the correct order) easier to grok.