From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 89FE03858D37 for ; Tue, 21 Mar 2023 14:17:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89FE03858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id D249D100417EA for ; Tue, 21 Mar 2023 14:17:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ecnapLVNkaaYZecnapwcyM; Tue, 21 Mar 2023 14:17:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=b813XvKx c=1 sm=1 tr=0 ts=6419bc6a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=YN9E2oBQNAMBZdrZx5EA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sV3ZkBrKlXCOcR+Tiu0nfv7s5rvpLpo5XIVYiF344WY=; b=bTLESR3L7OyZaTHpM6HFzM/myQ zbnBQ/VkhhP7yceGICvJXyN530+9eruuDec/TxEXx+LcsHwqBuR2XC/XzSG8Ej2CeF9KB0dqFPULu 2aZ3BFopdM+Ev85oZjtH+hjJT; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:34852 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pecna-000enp-CB; Tue, 21 Mar 2023 08:17:14 -0600 From: Tom Tromey To: Ulrich Weigand via Gdb-patches Cc: Aditya Kamath1 , "tom@tromey.com" , Ulrich Weigand , Sangamesh Mallayya , "simon.marchi@efficios.com" Subject: Re: [PATCH] Modify align-c/align-c++ test case for AIX References: <87edpwmzpz.fsf@tromey.com> <3636157c35660e96f2da98eb70cbac597d0a092c.camel@de.ibm.com> <87r0tqchea.fsf@tromey.com> <87zg8bave2.fsf@tromey.com> <61289f79c8c08ebe15112711954e1b05d49c92be.camel@de.ibm.com> X-Attribution: Tom Date: Tue, 21 Mar 2023 08:17:10 -0600 In-Reply-To: <61289f79c8c08ebe15112711954e1b05d49c92be.camel@de.ibm.com> (Ulrich Weigand via Gdb-patches's message of "Tue, 21 Mar 2023 07:41:40 +0000") Message-ID: <877cvagpeh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pecna-000enp-CB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (murgatroyd) [71.211.185.113]:34852 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Ulrich" == Ulrich Weigand via Gdb-patches writes: Ulrich> If the -bnogc flag is always necessary with the AIX linker, this Ulrich> should be handled automatically by the test instead of via site.exp. Ulrich> I'm assuming this is only needed with test files that use global Ulrich> variables unused in the source code, but used by the debugger. Ulrich> I think it would be best to explicitly add the flag to those tests Ulrich> where it is needed. I think there's also cases in the test suite where we've added uses of variables to ensure they aren't optimized away. With a comment somewhere explaining why, I'm also ok with that. It seems less intrusive maybe than adding ldflags to a lot of tests. Tom