public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>,
	Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Zheng <linuxmaker@163.com>, Tom Tromey <tom@tromey.com>,
	Zheng Zhan <zzlossdev@163.com>
Subject: Re: [PATCH] I'm debugging https://github.com/helix-editor/helix.git@63dcaae1b9083396fb3faaef9eaa2421f7e48fb9, which is a editor implemented with rust lang. When I type gdb command below: (gdb) b pars gdb dumped. I got: m_match = 0x7fffd8173cc7 "parse::h3bbecc5bbd82b347" m_ignored_ranges = { first = 0x7fffd8173cbb "<impl str>::parse::h3bbecc5bbd82b347", second = 0x7fffd8173cc5 "::parse::h3bbecc5bbd82b347" }
Date: Mon, 20 Mar 2023 16:08:02 +0000	[thread overview]
Message-ID: <877cvbe78d.fsf@redhat.com> (raw)
In-Reply-To: <87pm93h6ga.fsf@tromey.com>

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> commit 467065c7a25a6fc87fab6c73ac6d7d509aae81b6
> Andrew> Author: Andrew Burgess <aburgess@redhat.com>
> Andrew> Date:   Fri Jan 6 15:50:26 2023 +0000
>
> Andrew>     gdb: fix crash during command completion
>
> I forgot about this patch -- it fixes the same problem I just checked in
> a patch for.
>
> The two patches don't interfere.  I think your should still go in.
> Thanks.

Wow!  I'd completely lost track of this patch.

I added a small addendum to the commit message that references your
commit, and updated the new test to use 'requires', but otherwise pushed
this as is.

Thanks for remembering this.
Andrew


      reply	other threads:[~2023-03-20 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-02 12:43 Zheng Zhan Liang
2023-01-05 20:24 ` Tom Tromey
2023-01-06  3:01   ` linuxmaker
2023-01-06 15:53     ` Andrew Burgess
2023-01-07  8:58       ` Zheng
2023-01-12 19:06         ` Andrew Burgess
2023-01-13  5:24           ` Zheng
2023-01-13 14:46             ` Andrew Burgess
2023-03-20 13:56           ` Tom Tromey
2023-03-20 16:08             ` Andrew Burgess [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cvbe78d.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=linuxmaker@163.com \
    --cc=tom@tromey.com \
    --cc=zzlossdev@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).