From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 7A3683858D1E for ; Mon, 13 Mar 2023 20:11:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A3683858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd30.google.com with SMTP id k17so5529619iob.1 for ; Mon, 13 Mar 2023 13:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678738311; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aBdtIvsHKwtDMU1pLDILeVaoONXuqK2VeMOI6toqidI=; b=iav+hcq7xwiHwCoHYtH+en7+/sEFw19g1nT3Iuat/vS5QfS9TbuZjvgjGzZfciC6WG q3LsDzKTvzfQEYzeV8ZfFoH5jBPB3WgOfgP5Z6zfVBpkvGJ9Avg0MuV26YCp4HKG2LKw RsRNA1ncO/zZP0k80nkySr6bGGs7UQL23xbc0qhyPVa1zSuZS9pqkig6Mma3zIUbK//6 q+PaVgsFSoitcxfnfbTb3LrwjoDH+Cq0HMXbZtVDQrnyA4/bMkFUPR/3XjlhMrUyXWaJ 3oDHKwOhOv8LPMbtR39wLwezuN2bEYHOD1eSzPhoHzcRvtKPIjBgzUKRQ7eCaHqApp8R GN/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678738311; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aBdtIvsHKwtDMU1pLDILeVaoONXuqK2VeMOI6toqidI=; b=5f2tPzauQBpZ2Z3Qb81rx3HZl4iD47Kl9rsdNl/SVELKGb8fc8NC2oPXz2a1woTCaW P3OAINThNd6S9vRr8ZlgzXy5ca0ERKOBy5JAi9szL5UH/T63ABa5dOeQepvFMC2cp2R4 24Mc3NvGVTdah5rxCnPaYi3lfMmfyjFBgbV3pVdgN78aUn4FJdq5+h2ihsuh5K9fh5Vh teEha9tsztP+s/SzehYHen1mqZ7HGMaCsuQJ8JkX0rpBL0edz7dJ4JfJScrcy8YbtSce ueMx+0WFbsY5BVF7SlM5TqIxX8I4V+WgRlTDhX/zlwzuGK8KlShQLrkvY6U+7paB9PW3 HgdA== X-Gm-Message-State: AO0yUKWWzIPUmGBx8j9neouPiGHvNqusqQ20kW7KEJB/wMMQCxnKIQBa d1ZZAhB8eUwRUEvQL26BgTwSjQ== X-Google-Smtp-Source: AK7set/icdYhDVWlZQx83o9U4W4vGcHm/49umFZ9nLDDOgXVoOeWU0iU7YoA3MIOaVTf//fJrgEERA== X-Received: by 2002:a5d:8889:0:b0:746:1c75:233a with SMTP id d9-20020a5d8889000000b007461c75233amr21087835ioo.20.1678738311751; Mon, 13 Mar 2023 13:11:51 -0700 (PDT) Received: from murgatroyd (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id k8-20020a6b4008000000b0074ca38eb11fsm211022ioa.8.2023.03.13.13.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 13:11:51 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Fix crash in inside_main_func References: <20230224175124.2689187-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 13 Mar 2023 14:11:50 -0600 In-Reply-To: <20230224175124.2689187-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Fri, 24 Feb 2023 10:51:24 -0700") Message-ID: <877cvkl8c9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> gdb 13.1 crashes while running the rust compiler's debugger tests. Tom> The crash has a number of causes. ... Tom> Meanwhile, as I think it's important to fix this crash sooner rather Tom> than later, this patch changes inside_main_func to check that the Tom> symbol that is found is LOC_BLOCK. This perhaps should have been done Tom> in the first place, anyway. I'm checking this in now, to both git master and the gdb 13 branch Tom