From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 25C50385840F for ; Fri, 24 Feb 2023 19:54:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25C50385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 9E67D10046B3E for ; Fri, 24 Feb 2023 19:54:33 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Ve9Jpl6HwGvdIVe9JppMRw; Fri, 24 Feb 2023 19:54:33 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Sc4yytdu c=1 sm=1 tr=0 ts=63f915f9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=8USZzjMJy8HMkBBI8fgA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Es2kNLQSJhHdbO09vsObsFl8QEbN81IWbELhtTPRlLU=; b=XNvCeN20GTdCOmAyIdyqpDgyzK c9dIw0G6ACwoBe3Lkf/DOPmoDSE0t/Aw1L6xh3HH0tUnQWgZYnUr49A13kO7ncxmCABctNKX/gvuf EJNcGqA8i0pBNX1heI2a3z6DE; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37150 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVe9J-002NMu-4T; Fri, 24 Feb 2023 12:54:33 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 0/9] Add typing annotations to gdbarch*.py and make-target-delegates.py References: <20230223221830.499934-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 24 Feb 2023 12:54:29 -0700 In-Reply-To: <20230223221830.499934-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 23 Feb 2023 17:18:21 -0500") Message-ID: <877cw6hma2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pVe9J-002NMu-4T X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:37150 X-Source-Auth: tom+tromey.com X-Email-Count: 19 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> While investigating something related to a gdbarch method, I was trying Simon> to understand the purpose of the "invalid" Function parameter. It is Simon> sometimes passed a boolean and sometimes passed a string. This is Simon> indeed described in the comment at the top of gdbarch-components.py, but Simon> I then thought that if we used type annotations, it would make it clear Simon> that it's intended. Also, I find type annotations (when paired with a Simon> checker such as pyright or pylance) really handy to avoid all kinds of Simon> mistake. So I got a bit carried away, and this series is the result. This all seems fine to me, though I found one it. Reviewed-By: Tom Tromey Tom