From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 8984B3858D33 for ; Tue, 14 Feb 2023 22:16:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8984B3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 03F9410047D44 for ; Tue, 14 Feb 2023 22:16:22 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id S3b3pkCivjkdRS3b4pdr6E; Tue, 14 Feb 2023 22:16:22 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=LPqj/La9 c=1 sm=1 tr=0 ts=63ec0836 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=1EZhUsgdAWPYR1zdt-IA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dQrbFF5wryBO2uXwXFeZVI/S9gHIaCBTqJA3pvL1eVA=; b=hXoJoohxraSg9diib6n7sb3PFM hbEh1klBCGduYwa4Vap+x45ktJWvvLn0vBuh2Bq/07Y0BQ5F+TLmnxmaePgP3c2uZfXxwZ/XCn8M9 G4o7dhv4fUPEVSPaIem4QgbGN; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:49844 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pS3b3-000O7n-NS; Tue, 14 Feb 2023 15:16:21 -0700 From: Tom Tromey To: Alexandra Petlanova Hajkova Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix value chain use-after-free References: <20230211010805.3700057-1-tom@tromey.com> X-Attribution: Tom Date: Tue, 14 Feb 2023 15:16:18 -0700 In-Reply-To: (Alexandra Petlanova Hajkova's message of "Tue, 14 Feb 2023 18:05:01 +0100") Message-ID: <877cwjdhal.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pS3b3-000O7n-NS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:49844 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Alexandra> I think it's a good solution and I can confirm Alexandra> gdb.python/py-pp-cast.exp passes for me. But I wasn't able to Alexandra> apply the patch cleanly, I think it needs to be rebased. Thank you. I usually rebase if there are either changes required or before checking in. I also push all my patches to my github though it can be hard sometimes to figure out exactly what branch they're on. Tom