Re: [PATCH] Ensure all DAP requests are keyword-only

[Tom Tromey <tromey@adacore.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> -def set_breakpoint(source, *, breakpoints=[], **args):
>> +def set_breakpoint(*, source, breakpoints=[], **args):
>> if "path" not in source:
>> result = []
>> else:

Simon> IIUC , this function is called magically when receiving a setBreakpoints
Simon> request, and "source" comes from the request arguments?

Yes, that's right.  server.py does:

            body = _commands[params["command"]](**args)

Now, in theory it's possible to just call functions like this directly
from some other python code.  However, I think we should generally
prohibit this, and if it's needed, refactor to have some helper
function, to avoid combining protocol-layer code with implementation
code.

Simon> If so, the change makes sense to me, as there are no positional
Simon> arguments in DAP requests.

Thanks, I'm going to check it in.

Tom