From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 822D13858D33 for ; Tue, 31 Jan 2023 20:49:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 822D13858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id B8E051004921C for ; Tue, 31 Jan 2023 20:49:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id MxZ4p9jn6NX2aMxZ4pvpA1; Tue, 31 Jan 2023 20:49:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63d97eca a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=13KGAo4DAAAA:8 a=SEuo-1wFGAzrM7BnSHoA:9 a=0Frvj7WxKqMA:10:uccc_2email_address a=DdAeqqNASC6T8jxox_Jq:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fxk2kQZo1qUZc+WnKHDoYg76eOkq/9rBinKAS913Cz0=; b=qzfi/GTKb/2yB3oaNZ8ei14cNA tBmvwssNy0Ta6LPKrqerXe1yNaqIvfuQLWMi+xq3fpuW3/xz5tRlhZFA5EyykGEXf/dpmxyLKxXhI N4jT3RMjAoN56uzO392H5nddU; Received: from 71-211-157-143.hlrn.qwest.net ([71.211.157.143]:40780 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pMxZ4-004AZ8-1m; Tue, 31 Jan 2023 13:49:14 -0700 From: Tom Tromey To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Andrew Burgess , Tom Tromey , Richard Bunt Subject: Re: [PATCH v3 5/5] GDB: Introduce limited array lengths while printing values References: X-Attribution: Tom Date: Tue, 31 Jan 2023 13:49:10 -0700 In-Reply-To: (Maciej W. Rozycki's message of "Mon, 23 Jan 2023 23:14:35 +0000 (GMT)") Message-ID: <877cx2l9a1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.157.143 X-Source-L: No X-Exim-ID: 1pMxZ4-004AZ8-1m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-157-143.hlrn.qwest.net (murgatroyd) [71.211.157.143]:40780 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Maciej" == Maciej W Rozycki writes: Maciej> From: Andrew Burgess Maciej> This commit introduces the idea of loading only part of an array in Maciej> order to print it, what I call "limited length" arrays. Maciej> The motivation behind this work is to make it possible to print slices Maciej> of very large arrays, where very large means bigger than Maciej> `max-value-size'. Thanks for the patch. Maciej> +/* Try to limit ourselves to only fetching the limited number of Maciej> + elements. However, if this limited number of elements still Maciej> + puts us over max_value_size, then we still throw an error. */ Maciej> + Maciej> +static bool Maciej> +set_limited_array_length (struct value *val) I think the comment is slightly incorrect, in that this doesn't seem to throw, but instead returns false. Other than this nit (no need to resubmit for this), I think this is ok. Tom