From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 16F853858D28 for ; Tue, 17 Jan 2023 18:46:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 16F853858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12c.google.com with SMTP id h26so15823465ila.11 for ; Tue, 17 Jan 2023 10:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=oQBmDKSREvItU/HVhcLunDwbMKzsPEOHxryLLdsr/HI=; b=Gj0OMV8oualCd1H19YAKt51LqAUbh4NFoRbNF0JNGGv/U9kE/95fFETK3ZbVd4OSiS qtCd8z2ocXSQxjL7fqE8IQ+DsikWnT88+tgScDGx+eifBbi5FQ8HyUJK1r0nIKxAON5N nZgnFdRjGlfLe3XE1VIhjs7Od3b9BNhUSxAf5zkLY2+XGoA5P34qJGbefC6p00JfZQ+M WFPHV/u67FL7xcOzgXWnHhHaBIkC2rMwskdJuDhE4++N8eSHajpziHsBoRW3Y85Y18Zq fpkV09ehTJ9J4f3XAZiIyGlwmc4JGx4UHp9DhaNuvIFPUUZgIu5f70chgZ8tKZ/5jrqq rMiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oQBmDKSREvItU/HVhcLunDwbMKzsPEOHxryLLdsr/HI=; b=2hvuJWZK34UnM3XGnV8KASeEnjFGbLdkAWX23SSZV3FaPb1mrvuRb+qBI0w2lNvdCM Pl95aVr3LA3LxpxLaBLNCHuDmKqr2x5vRrs/K2DOZnCHTYRV1giZK7YCgitCiPLqgcqQ UfXuwZaBthMl2hrDZObRpQr+Uhf9nv1faYcvUL210hTlcZQTheBlpPlheagOOcSet2UB ISR0xAB/TP4YaQpZqIeOnPxMf8AgANuA6QYKpqJYNWoVgyzrYEq93BX1NnxesSAeqANC LIuL4mk+Zo41/ZytcvcXOrp1OaU7yXDjitIpCMMttc+1E9b+0+umozblgEIwGXJGv4ot lNfg== X-Gm-Message-State: AFqh2kq05YqM8ZzWYsFIYtVhmj6vE7v1DOc3yGjnGABob/J6QQyeaaVT fyLN/EW3z5vrdFoRkeLWMpB8QA== X-Google-Smtp-Source: AMrXdXs6YhcZDzYEUXT8bQVD7FY2hvuJ1nGxoZGZTeeAa7mYYvp8qHPSBHtYJHGuCxxAnU60QtMLtw== X-Received: by 2002:a92:d24a:0:b0:308:dfac:9aaa with SMTP id v10-20020a92d24a000000b00308dfac9aaamr18513470ilg.20.1673981200349; Tue, 17 Jan 2023 10:46:40 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id h10-20020a02c72a000000b0038a2f576b54sm3573754jao.54.2023.01.17.10.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 10:46:39 -0800 (PST) From: Tom Tromey To: Tom de Vries Cc: Joel Brobecker , Tom Tromey via Gdb-patches , Tom Tromey Subject: Re: [PATCH v2 4/4] Fix parameter-less template regression in new DWARF reader References: <20230110183338.2623088-1-tromey@adacore.com> <20230110183338.2623088-5-tromey@adacore.com> X-Attribution: Tom Date: Tue, 17 Jan 2023 11:46:39 -0700 In-Reply-To: (Tom de Vries's message of "Tue, 17 Jan 2023 17:44:51 +0100") Message-ID: <877cxl2e40.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> On 1/14/23 07:11, Joel Brobecker via Gdb-patches wrote: >> +if { [skip_cplus_tests] } { continue } Tom> This uses the old syntax, so we get: Tom> ... Tom> ERROR: tcl error sourcing src/gdb/testsuite/gdb.cp/paramless.exp. Tom> ERROR: invalid command name "skip_cplus_tests" Tom> while executing Tom> ... Sorry about that. I see now that my test comparison script doesn't account for ERROR / UNRESOLVED :( I'm going to check in the appended. Tom commit fbd6525ba66d9c6c98cf57223d6ad09df1274d67 Author: Tom Tromey Date: Tue Jan 17 11:45:40 2023 -0700 Use require in paramless.exp The new paramless.exp test was not converted to the new "require" approach. This patch fixes the problem. diff --git a/gdb/testsuite/gdb.cp/paramless.exp b/gdb/testsuite/gdb.cp/paramless.exp index 79529de49f5..579f363d6a0 100644 --- a/gdb/testsuite/gdb.cp/paramless.exp +++ b/gdb/testsuite/gdb.cp/paramless.exp @@ -17,7 +17,7 @@ # Test template breakpoints without parameters. -if { [skip_cplus_tests] } { continue } +require allow_cplus_tests standard_testfile .cc