From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 82E923858D28 for ; Fri, 6 Jan 2023 02:47:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82E923858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id A51BF10048EA4 for ; Fri, 6 Jan 2023 02:47:17 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DclJp5wWjSnieDclJpPTuw; Fri, 06 Jan 2023 02:47:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=IJ3HtijG c=1 sm=1 tr=0 ts=63b78bb5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=OfDALoH0Y6BLG3NAiIQA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7KaxZwRFw43A9TAk1HCuiOYBX2omZuReO2WjCj31zuc=; b=AF63RlYZN1rbqyxV9eiZaxrh9y 3YpO2tHXnZd7UT+6KC20M34BYNsv9PCLQge5NWsR/a692pkvX1JQnh5QQF1Epw++YnVtiXVQm6Rd8 dwFJ+v1XRy2yzpejbgPdL/zEJ; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:43458 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pDclJ-001TTT-9n; Thu, 05 Jan 2023 19:47:17 -0700 From: Tom Tromey To: Kevin Buettner Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/46] Rewrite "require" test procedure and use it more often References: <20221217000818.3729389-1-tom@tromey.com> <20230104182923.79a512ef@f37-zws-1> X-Attribution: Tom Date: Thu, 05 Jan 2023 19:47:14 -0700 In-Reply-To: <20230104182923.79a512ef@f37-zws-1> (Kevin Buettner's message of "Wed, 4 Jan 2023 18:29:23 -0700") Message-ID: <877cy08jm5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pDclJ-001TTT-9n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (prentzel) [97.122.76.186]:43458 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Kevin> One thing that I find a little odd (due to a sort of double negation) is the Kevin> construct: Kevin> require !skip_something ... Kevin> I see that Markus Metzger also commented on this and also that you Kevin> noted that this could be improved over time. (Which is fine with me.) It would be pretty easy to just convert them all. What non-negative name would be good? "test_"? "allow_"? "enable_"? Kevin> So... LGTM. Thanks. I will put it in reasonably soon, though if we pick a good name I will do that first and send a v2. Tom