From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6D2A03833E8F for ; Thu, 15 Dec 2022 11:22:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D2A03833E8F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671103374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7l+QONvT7vnZeSGM5LP3WVlArCtnhK3wbsM/bwCPk34=; b=H+iAXEAoCjyv3BqJ5h7o+B1tes7RMNaVnudjiBb+8k6SyFZLdEjggJakLQywBwAfFDoyas /eRpUDSd2Dst2yemRcASSvojkkZBNX0V8YIXsSC4PXq1y0ZDZhfSGi16OFx/5Hluug3XY6 ujRe0WD8qbQyaO0FYSVmrusAZAKOWGk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-259-5iMwVenrMimfCo0VRply5w-1; Thu, 15 Dec 2022 06:22:52 -0500 X-MC-Unique: 5iMwVenrMimfCo0VRply5w-1 Received: by mail-wm1-f69.google.com with SMTP id o5-20020a05600c510500b003cfca1a327fso7743586wms.8 for ; Thu, 15 Dec 2022 03:22:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7l+QONvT7vnZeSGM5LP3WVlArCtnhK3wbsM/bwCPk34=; b=xfNwMA8vnT7VW7jhX7N5zObiYV/0BMNFL014K4yl4aRH5LwwfI8MZ3uMmNWYLc+YNY KlnR4jU3j84ssBsGxTI5POZW8tmjP8j5ZFvnhU9jkddKB2QZqculiCLTYA/mguzxlQKM cQIB4UxFQD08DNE2m7rh39KpXofOUYEuLVhZ2RX185xTaVsN6d2hxuFdvzwes3CvNNWD RD9dOCww+kqXZfwNjo1v5VxiBhSKzcBWN5VN82Zx6WxeGV1u3TV+ciJXxAnrKjEJp0G2 jIrn1VYBZ5zFulkd3JwzWKBbriTrvcHQZkZhc5EB8Aj14i2xlIbVJidk64xjvk5JDf1A iD9w== X-Gm-Message-State: ANoB5pmddGvvcBuiBSKnYtHwvl3m7ifsQ14OTqns9ldPnFB42nn2Mcs8 wCWamtgg5WlhFLLviBi8HcS5zR3CgjIfF2GImtXaN35yJN1Zu94Hfnm+FiJFuIu47byd91GY3FG /+IWxu9mL6AmqIzroUAn5IA== X-Received: by 2002:a05:6000:11cf:b0:242:2e74:7930 with SMTP id i15-20020a05600011cf00b002422e747930mr17514832wrx.10.1671103371867; Thu, 15 Dec 2022 03:22:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf6qA3OETCcxHDZ9HYahG2UXqW6l01NlwgyhTsK3thn/B9hx/JestL4TGosPi5zL/cg2IC3NWA== X-Received: by 2002:a05:6000:11cf:b0:242:2e74:7930 with SMTP id i15-20020a05600011cf00b002422e747930mr17514821wrx.10.1671103371551; Thu, 15 Dec 2022 03:22:51 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id s18-20020a5d4ed2000000b00242271fd2besm5662038wrv.89.2022.12.15.03.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 03:22:51 -0800 (PST) From: Andrew Burgess To: Luis Machado , Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 2/2] gdb/testsuite: new test for recent dwarf reader issue In-Reply-To: <286c40e2-3bde-91f2-32a2-485b6243bc93@arm.com> References: <87lengh250.fsf@tromey.com> <875yek2xdo.fsf@redhat.com> <286c40e2-3bde-91f2-32a2-485b6243bc93@arm.com> Date: Thu, 15 Dec 2022 11:22:49 +0000 Message-ID: <877cys29o6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Luis Machado writes: > Hi Andrew, > > On 12/9/22 19:24, Andrew Burgess via Gdb-patches wrote: >> Tom Tromey writes: >> >>>>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: >>> >>> Thank you for doing this. >>> >>> Andrew> - However, GDB checks each partial symbol using multiple languages, >>> Andrew> not just the current language (C in this case), so, when GDB >>> Andrew> checks using the C++ language, the symbol name is first demangled, >>> Andrew> the code that does this can be found >>> Andrew> lookup_name_info::language_lookup_name. As the demangled form of >>> Andrew> 'signed int' is just 'int', GDB then looks for any symbols with >>> Andrew> the name 'int', most partial symtabs will contain such a symbol, >>> Andrew> so GDB ends up expanding pretty much every symtab. >>> >>> It's a pedantic point but what happens here is name canonicalization, >>> not demangling. Demangling is just used to refer to the translation >>> from a name like "_Zmumble" to "something::else" -- that is, the input >>> is a linkage name and the output is a C++ name. Canonicalization takes >>> a C++ name as input and returns the standard form, basically dealing >>> with the fact that C++ (and as we discovered, C) has multiple possible >>> spellings for some symbols. >> >> Please, be pedantic. My goal here was to better understand this code, >> there's no point me understanding it wrong. >> >> I'll reword that paragraph. >> >> Thanks for taking a look. >> >> Andrew >> > > I'm not saying you should investigate this, as it is a new test, but I'm getting a lot of these messages for this test: > > ERROR: internal buffer is full. Happy to take a look at the problem. I guess the issue is coming from the gdb_test_multiple that I use in the new test script. I'm tried to write patterns that match and discard all the lines as they arrive from GDB. I guess you are seeing a pattern that I am not for some reason. Could you run just this test and attach the gdb.log file and I'll take a look. I probably just need to tweak one of the patterns a little. Thanks, Andrew