From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 07C1A3858D35 for ; Tue, 29 Nov 2022 04:32:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07C1A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-142306beb9aso15634715fac.11 for ; Mon, 28 Nov 2022 20:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=kiLV3qettMmbUnBRQ66siC+D+sn9MdH3h56Z+nYQ46Q=; b=ddlSXqNzxJFvXScaB8l+Pzj7B6MiuSZGbcXVAuMPUthyOrb/yi3QafdG3A5GYsilrJ Vbo2dz57QoSH7ezOmELHoMnMIrrxgt8hOC8LtTpwyjGuk/EViso4Alt1lmrX+vPKHqRQ wUHgcjqdT5QFW70bcTp+ktbNlMMU1ALTFM/otedK7YNIgtGUm5cMVZhteiGi7rCS1c1/ szQn6Pgd1AHVc4b+09333KHRuQmW0vsosXvb93fztIOkrx/7QId++q+a3MbovOW4qER/ GzaB2SncHyPj6irktfdPORgO71eox2nfk2lC9ZzYWAp667nUK9sobK8nNJL5CbUZ5g8o Lc2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kiLV3qettMmbUnBRQ66siC+D+sn9MdH3h56Z+nYQ46Q=; b=bIohEdIihNbRqXsuUH59jgrFcLuCKao9V6y3RVFVDeJcZ7zrtwtEZYEr48Elsug+ie /8ziXUli8Y1sRcU4tXrIw68Yu4FQ6eUnKHbzsVQQl+capvHPLPba6W9DMzEEyLpI9z66 LlAe7ZZIzvQNprp7RtUhW1bnX++rnBBeKC8ZnbenBiuyIILp2zC/fu308ug0c/Cj2A11 /HW/kxBtpF7r5E75NSsr55eHFJOge1ZD307bmO97WTpGHVEmc7KxmfaOL5C45GYSlAXZ In0IZuyHPU4AmG0f7V2+rqBxw2VkpmnjhmXWaTg6rG8bLYGxXUjGqtYheoEyRLmzHjam jmZg== X-Gm-Message-State: ANoB5plURsdJStI6gXD33rywNjc0KIDU1pduelEuhofeQPFW8V/Vg4U+ Dq830z8qMWWPh/uN8O4SmHEaOQ== X-Google-Smtp-Source: AA0mqf57KH76r4JEFCVpv3DfOgvJiDhtWtq6jrqQLMZoM9uMQCnmFc5/nIGR9kw/wqN4QO5YW8lwow== X-Received: by 2002:a05:6870:b69b:b0:143:1c42:8897 with SMTP id cy27-20020a056870b69b00b001431c428897mr18120719oab.38.1669696335461; Mon, 28 Nov 2022 20:32:15 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:201c:ea26:41ce:5eb]) by smtp.gmail.com with ESMTPSA id q1-20020a9d4b01000000b0066cc88749f8sm5427479otf.68.2022.11.28.20.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 20:32:15 -0800 (PST) References: <20221126020452.1686509-1-thiago.bauermann@linaro.org> <20221126020452.1686509-6-thiago.bauermann@linaro.org> <832ac76f-4cc1-1ab4-a80c-f4d92005ea7e@arm.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 5/6] gdb/aarch64: Factor out most of the thread_architecture method In-reply-to: <832ac76f-4cc1-1ab4-a80c-f4d92005ea7e@arm.com> Date: Tue, 29 Nov 2022 04:32:12 +0000 Message-ID: <877czegz3n.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Luis Machado writes: > On 11/26/22 02:04, Thiago Jung Bauermann wrote: >> The same logic will be used by a subsequent commit when remotely debugging >> an aarch64-linux target. >> The code isn't changed, just moved around. >> --- >> gdb/aarch64-linux-nat.c | 28 ++-------------------------- >> gdb/aarch64-tdep.c | 35 +++++++++++++++++++++++++++++++++++ >> gdb/aarch64-tdep.h | 2 ++ >> 3 files changed, 39 insertions(+), 26 deletions(-) > > LGTM. > > Approved-by: Luis Machado Thanks! Added the Approved-by tag to the patch description for v3. -- Thiago