From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 715C13858C39 for ; Tue, 29 Nov 2022 02:56:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 715C13858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-142612a5454so15495489fac.2 for ; Mon, 28 Nov 2022 18:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=NulgRAKgW2I80arbBNX3SEQ8JbnbVYzNsPBFCMgguHU=; b=v3M42X8vMxOW3dccdpg+N3iyKqgghnf8fCo74K+RpfeRK8zSPxL/BlH1uZXsUTWE4T buOckF0oYRDaCIeHeAsPvXidRiCFdcUBdKorlacjCpKRc6p1lp6kEkDhYlb3yogFkbnX /u3Td7yI07ESvunm71l8NcJm1G+1n/K+oIcRLf/ifx9vvgiJbO0FwLU6MR+zsS0w4Y0t 1vrIYeWt8JxFDn/0o5RmjJ0xcgvG96ek1Agh5kBmkm7DLrzVhwt2AA7WZ11qukFkXAnr 3fnbN0u6r/+jkOwWExVUltp185t2gcXfIqm4ijsoBODrgY1OiU6n2CQCly+2Omk7FHXn QoZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NulgRAKgW2I80arbBNX3SEQ8JbnbVYzNsPBFCMgguHU=; b=ZZ9qtikUvSoqUfKB238SqWlgP0rxncpqmOYLepvmxjP1diS/JCPGo0cck4+SPHXZMM 83D6cJwHVEQ6wxt6SOBj/AeB1SNELbvPB3WRqIly+RCO3czir/PXX/p1cxZgkHlQciyk bF5Vz0KlaXhV2nil/rGh6RvQsFzE8fuv9743c5s+ssKgLMQb5O5eAbpp15IX9Uv2Jrzz Yz/izye0e7JMtQ/laPKB1IsENVxF3xQ0J9K0S1kKpoBcGK1dDOJjX0HgoTxUNRBNgTYC incyUlEVnVYkv+ZpHvKAGdI0UnYi2rASlIUuCHpeTL0CTmKgd2rHAjoK/lSmqn3x2M/5 oL0A== X-Gm-Message-State: ANoB5pnIL2eNvvatUXICSi2pX5EV9HFMe8UgHIDr5qanEWa2LvH6RxfD Z7YOhtBQVbxBA8XXTrdqKyCisNg7NyWMjA== X-Google-Smtp-Source: AA0mqf48YVnXxpeg/mzqslXRimUCZmWBylK7STbEm17H4j/nExHcv+YHG1ucpekCK5xIo1Y69s/XMw== X-Received: by 2002:a05:6870:430a:b0:13d:5167:43e3 with SMTP id w10-20020a056870430a00b0013d516743e3mr21290482oah.257.1669690563584; Mon, 28 Nov 2022 18:56:03 -0800 (PST) Received: from localhost ([189.4.186.22]) by smtp.gmail.com with ESMTPSA id r19-20020a056870581300b001438e8f097asm3987344oap.58.2022.11.28.18.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 18:56:03 -0800 (PST) References: <20221126020452.1686509-1-thiago.bauermann@linaro.org> <20221126020452.1686509-2-thiago.bauermann@linaro.org> <205c734b-ef38-1b05-3737-81872ff6563d@arm.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/6] gdbserver: Add asserts in register_size and register_data functions In-reply-to: <205c734b-ef38-1b05-3737-81872ff6563d@arm.com> Date: Tue, 29 Nov 2022 02:53:49 +0000 Message-ID: <877czeii82.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Luis, Thank you for the quick review! Luis Machado writes: > On 11/26/22 02:04, Thiago Jung Bauermann wrote: >> These helped me during development, catching bugs closer to when they >> actually happened. >> --- >> gdbserver/regcache.cc | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc >> index 5cbcea978a05..14236069f712 100644 >> --- a/gdbserver/regcache.cc >> +++ b/gdbserver/regcache.cc >> @@ -286,6 +286,8 @@ register_cache_size (const struct target_desc *tdesc) >> int >> register_size (const struct target_desc *tdesc, int n) >> { >> + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ()); >> + >> return find_register_by_number (tdesc, n).size / 8; >> } >> @@ -300,6 +302,8 @@ regcache_register_size (const struct regcache *regcache, int n) >> static unsigned char * >> register_data (const struct regcache *regcache, int n) >> { >> + gdb_assert(n >= 0 && n < regcache->tdesc->reg_defs.size()); >> + >> return (regcache->registers >> + find_register_by_number (regcache->tdesc, n).offset / 8); >> } > > LGTM. > > Reviewed-by: Luis Machado With Simon's suggestion, this patch will be different in v3 so unfortunately I won't be able to add this Reviewed-by. -- Thiago