From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id F3511384518E for ; Sat, 26 Nov 2022 01:36:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3511384518E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x32f.google.com with SMTP id g51-20020a9d12b6000000b0066dbea0d203so3641576otg.6 for ; Fri, 25 Nov 2022 17:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=xQg3iD4w8we6oezYHL0/NLc8NynJPB30rnY2/qbsj4U=; b=PG9Wj/uN6Qhy0L3JQR5744TSW5HQeQcW+jBYqf5LmQDwXZy49ytoefkNXiFAE+BETN OuuK61fpMZUcOFlqlYMEynhN1SeCzEVFO0yWWn0i6PZzNPqdSl5TjtdLiMIJY6pNcKIy BZhnlkxeCRc8r2GZfAF2+y/Yni0TwVDibMP+FC5rxmXrvKn0sLX+K/n5OWWr6IUhXjyL cb+3BufWodEi4BYnr10h4DM8PTHjygI+SwL1PQNhGqrr1PkONOpm3P7btKMAkQ0dX1NU 0CnxJo0SN5MYy7YHgrGTrcSrVsqoCYM3HXc8nRA4hQaiWGrtCSCViPwXAg7uZgMbskey Z6QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xQg3iD4w8we6oezYHL0/NLc8NynJPB30rnY2/qbsj4U=; b=7WDRgYfxUL7rJQ2aqRRK9JKRhzKMYYj1mhYaoncbzYyBPRcG24W+Sb0HCZ9oOtsHgs SO0JytWIxC6Bo86A3wfG2JvrpCCnDQ7vcU7btf5VCMSHp9CfdRyG42smwWzkYF+44J1U UxbX/5Oehnk0lniD6Xzg8sdotl4FHoekS2bw7+W2CfUsCOCugtzRtB5yp8TN7XpZrrDD 2wu/K/G+a1aUcyU30qoMYlLwneOEYwq8o56QH8zXC75nS/vPC339/wueJah3Mk1EFfRQ jT8SNtohkg1drIf/TdJ5ZW9y3TzTZeYhulEFy9GOoJBhOFog3hxiaDUyDukvh/31IPhO /C6g== X-Gm-Message-State: ANoB5pnqPoce7mK2SeI1owqq4GrGwhREa5KegLa0+2l+JPqKGVPxkelE B9O30vX3vbuvhKBdL/t6+NCHUg== X-Google-Smtp-Source: AA0mqf7Fmm1AXxxKG4M0lQjvV2YAmZlvOOw+/kHFG6iCZBvvaE17WHbyDhBwJwUqjsDWw/EBni+rRg== X-Received: by 2002:a9d:5e0b:0:b0:661:943e:92e2 with SMTP id d11-20020a9d5e0b000000b00661943e92e2mr14525756oti.362.1669426573246; Fri, 25 Nov 2022 17:36:13 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:41ee:c7fc:c991:eee6]) by smtp.gmail.com with ESMTPSA id h9-20020a4ad009000000b0049be9c3c15dsm2094078oor.33.2022.11.25.17.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 17:36:12 -0800 (PST) References: <20220908064151.3959930-1-thiago.bauermann@linaro.org> <20220908064151.3959930-2-thiago.bauermann@linaro.org> <2912eb5f-44e0-9aa4-50d1-61af7d09050d@arm.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] gdbserver: Add asserts in register_size and register_data functions In-reply-to: <2912eb5f-44e0-9aa4-50d1-61af7d09050d@arm.com> Date: Sat, 26 Nov 2022 01:36:09 +0000 Message-ID: <877czia452.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Luis, Sorry to take this long to respond. I'm posting v2 to address your feedback. Thank you very much for reviewing these patches! Luis Machado writes: > On 9/8/22 07:41, Thiago Jung Bauermann via Gdb-patches wrote: >> These helped me during development, catching bugs closer to when they >> actually happened. >> --- >> gdbserver/regcache.cc | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc >> index 27491efc52d5..ebaeb5e86895 100644 >> --- a/gdbserver/regcache.cc >> +++ b/gdbserver/regcache.cc >> @@ -286,6 +286,8 @@ register_cache_size (const struct target_desc *tdesc) >> int >> register_size (const struct target_desc *tdesc, int n) >> { >> + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ()); >> + >> return find_register_by_number (tdesc, n).size / 8; >> } >> @@ -300,6 +302,8 @@ regcache_register_size (const struct regcache *regcache, int n) >> static unsigned char * >> register_data (const struct regcache *regcache, int n) >> { >> + gdb_assert(n >= 0 && n < regcache->tdesc->reg_defs.size()); >> + >> return (regcache->registers >> + find_register_by_number (regcache->tdesc, n).offset / 8); >> } > > LGTM. Someone else must approve, but I suppose it could go in on its own. Thanks! This patch is unchanged in v2. -- Thiago