From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 369CB385800A for ; Wed, 21 Sep 2022 15:31:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 369CB385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 7DE4C10048AD3 for ; Wed, 21 Sep 2022 15:31:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id b1grocYduvlAab1gsog2um; Wed, 21 Sep 2022 15:31:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=S+wcfKgP c=1 sm=1 tr=0 ts=632b2e3e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=rVPTDvnFrstMGdNhDb8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W5smc/WePVdyotjwdqRRc6SaK5GeAyRmC8darXM0rK0=; b=ydaPU7ggiLxYoExV0KoGpQPRwi nAavoXfNZVY/EnGyHVJ5nAncVH5FKdox7XrGAUzA+WZz+/AZRHbl4f+/hHsrD8SWB4eRYkHDH4WSN oN64sKmceXIPhceLOmsNOf6iM; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56532 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ob1gq-000Rym-Vo; Wed, 21 Sep 2022 09:31:09 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH] gdbsupport: change path_join parameter to std::vector References: <20220719142741.3307396-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 21 Sep 2022 09:31:02 -0600 In-Reply-To: <20220719142741.3307396-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 19 Jul 2022 10:27:41 -0400") Message-ID: <877d1w4udl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ob1gq-000Rym-Vo X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56532 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 15:31:51 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> When a GDB built with -D_GLIBCXX_DEBUG=1 reads a binary with a single Simon> character name, we hit this assertion failure: [...] Simon> This patch makes the easy fix, that is to change the path_join parameter Simon> from a vector of to a vector of `const char *`. Another solution would Simon> be to introduce a non-standard gdb::cstring_view class, which would be a Simon> view over a null-terminated string. With that class, it would be Simon> correct to access index 1, it would yield the NUL character. If there Simon> is interest in having this class (it has been mentioned a few times in Simon> the past) I can do it and use it here. I think it's fine to just do this for the time being. Thank you. Tom