From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by sourceware.org (Postfix) with ESMTPS id E477E3858D1E for ; Thu, 18 Aug 2022 14:08:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E477E3858D1E Received: by mail-vk1-xa2b.google.com with SMTP id j11so818793vkk.11 for ; Thu, 18 Aug 2022 07:08:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc; bh=4A6A2WGd3GI5IpAD8fx0r+dhrgBMuMAHvJOavrdz7Ec=; b=LDNreTqWG/Po7Sufj4SFf8O6pSwpixZ5ukT2C2FBRdM+OmF874V0HGZDGCiELL+8C9 jMFtcIJtZNqJCbFS9e8nIsl4QhIQZDU6AYBD+Yi1btYWj1lhIVi5B1OVlHS19iMEB3RM xiQh4nzLD4qACVNWlGzi9Gf4OXcTAiG4m+58Fw6/YYzRdWDRo//LLVkAmd849PzWnLg4 ldCCqMwMkMmpnwq4Kbt3C5868NkY2dojnPOBWhNWs9823ol6AGvBeq1a9Bg4vzoMoDVI o6Tde92sTexKkk/mFrwg+6SpbpmkkpfnxCcnCh6X75dL0q+HKLpm5C6UISi08ivjRBGe uOQA== X-Gm-Message-State: ACgBeo0So8PPD4i0a7Ms2NW7BimjQ5cCbJ1sN6oxm0BaZg0bQB/jGsoa HUQsANYCH6f9MXVHbwhxsqNyrg== X-Google-Smtp-Source: AA6agR5vPGxSpmHHFng4ISP158+fG57DF+w4MjttyES+YOs9vJ18VntEEH4DGJqiKpmRrsp2vDhdCQ== X-Received: by 2002:a1f:3803:0:b0:378:bd6f:249d with SMTP id f3-20020a1f3803000000b00378bd6f249dmr1168728vka.13.1660831686166; Thu, 18 Aug 2022 07:08:06 -0700 (PDT) Received: from localhost ([2804:14c:8780:89d8:3b79:a6db:9142:5828]) by smtp.gmail.com with ESMTPSA id i187-20020a1f6dc4000000b00379185401e2sm896035vkc.11.2022.08.18.07.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Aug 2022 07:08:05 -0700 (PDT) References: <20220805004648.111358-1-thiago.bauermann@linaro.org> <20220805004648.111358-3-thiago.bauermann@linaro.org> <87o7wynyet.fsf@linaro.org> <87mtc24mzz.fsf@linaro.org> <71903004-a93e-d879-6bd6-7e4c9e9c1561@arm.com> <87fsht4wb6.fsf@linaro.org> <2d6bf616-eb57-ba11-98ca-c57aff9bee9c@arm.com> User-agent: mu4e 1.8.8; emacs 28.1 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] gdb/testsuite: Add test for AArch64 Scalable Vector Extension In-reply-to: <2d6bf616-eb57-ba11-98ca-c57aff9bee9c@arm.com> Date: Thu, 18 Aug 2022 14:08:03 +0000 Message-ID: <877d354pbw.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 14:08:09 -0000 Luis Machado writes: > On 8/18/22 12:37, Thiago Jung Bauermann wrote: >> Hi Luis, >> Luis Machado writes: >> >>> On 8/17/22 21:46, Thiago Jung Bauermann wrote: >>>> Hello, >>>> Thiago Jung Bauermann writes: >>>> >>>>> Luis Machado writes: >>>>> >>>>>> This looks good to me overall. I'd be more comfortable with someone >>>>>> else approving the generic bits (though they look quite obvious to >>>>>> me). >>>>> >>>>> Ok, hopefully others will agree. :-) >>>> Ping... Does any other maintainer have an opinion on the generic parts >>>> of this patch series? >>>> >>> >>> I think this can be pushed, as it is merely moving/sharing a bit of generic testsuite >>> code. Seems obvious enough. >>> >>> Same thing for the other patch cleaning up the once-SPU-specific id field. >> Nice, thank you! I don't have commit access to the git repository, so >> would it be possible for you or some other committer to push them for >> me? I just verified that the patches still apply cleanly. >> > > Pushed now. Thanks! Thank you! -- Thiago