From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id A37B838582A1 for ; Tue, 16 Aug 2022 13:57:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A37B838582A1 Received: by mail-il1-x136.google.com with SMTP id j20so5385640ila.6 for ; Tue, 16 Aug 2022 06:57:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=U1AUT+nrDrm4gGs85oa47TnZtaPj8pPWpZqQSGM+BXA=; b=kYCHdjzOpLLr1daAYONvIMs5J7JrzOlv5S/coV/892xCamWp7wbqKtlTLvMDjqFGdJ 9e99LoIYxtYfsJa+yhl+APyFDU2niKZMooQEXXxtqM+r2xL/S20vFez0MYPdL1xQ/g8r efUR/1sAQ09xv9F8dLZHfyIlyX6zTBFGBjwqa0T9kfj8H8rn0zsLIkEHzxW5FdoESZxm Peyxf0dK2+NTf/N0OFG8LRwmU55mkFt+LOT9d1lwMND+afH/6FO62URNVESwgR9iw18+ aFH1GqWJYMjv0Z7CaEv4wNRUmn66W7ljY1waFi/82Fz24IWBWriS/n9pNXuQUFN84yZl 7Mlw== X-Gm-Message-State: ACgBeo0do2VWY7JTlLdzI6IAnTqwiCqQEJWKi7KbTGBDMyQPdSoQE28R i9P430JYRhocoe4pqqTXmSEJ7A== X-Google-Smtp-Source: AA6agR7pw7aHIrNPRvs59Gr/f3wdeJMNe87Ii/I9EN3hUtVkXQp/SgRX0kAqgV8sHQOoNU6eV/iRrA== X-Received: by 2002:a05:6e02:188b:b0:2de:84f3:ad8d with SMTP id o11-20020a056e02188b00b002de84f3ad8dmr9126430ilu.312.1660658253966; Tue, 16 Aug 2022 06:57:33 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id a4-20020a92c704000000b002e6c7382d85sm614118ilp.71.2022.08.16.06.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 06:57:33 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Use strwinerror in gdb/windows-nat.c References: <20220728170555.85143-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 16 Aug 2022 07:57:32 -0600 In-Reply-To: <20220728170555.85143-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 28 Jul 2022 11:05:55 -0600") Message-ID: <877d38e1f7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 13:57:35 -0000 >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> When working on windows-nat.c, it's useful to see an error message in Tom> addition to the error number given by GetLastError. This patch moves Tom> strwinerror from gdbserver to gdbsupport, and then updates Tom> windows-nat.c to use it. A couple of minor changes to strwinerror Tom> (constify the return type and use the ARRAY_SIZE macro) are also Tom> included. I'm checking this in now. Tom