From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EB7CD3858C55 for ; Mon, 25 Jul 2022 13:37:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB7CD3858C55 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-bk2YYBQWM4SZ_aG68Cj-xA-1; Mon, 25 Jul 2022 09:37:47 -0400 X-MC-Unique: bk2YYBQWM4SZ_aG68Cj-xA-1 Received: by mail-wm1-f72.google.com with SMTP id 2-20020a1c0202000000b003a3497306a8so1176329wmc.9 for ; Mon, 25 Jul 2022 06:37:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=TXTmM7xEuv1GMdao36Ot23A+AlJwCEOIkGNyZ3zqre0=; b=vvBfMPaU3hcAiAGRYlyFUnP0XJYkK4Alcqvj9kjE6bmwZD7JnCvk9mG8k020yqKTfQ Hm5lc+vqiHsTKppzChlITcSvQz0E8elpvnWcoxzcKZ3O4I+tjLotMuUOOQJqIXHxA1ir PedQcoC+tvvNii2DuqSPos+w/Pyxkvzyi51WZprghniyWgXww2uGMfedhhJj2O3VxXLV MH69njSMlEgezw+KoJsSPOl9QK+GdLQstDeUt152MTyVdntPN7Wsv3QIl9r2CJNcIJDb adnq3erGvm1yfH5h+8aZWvd23vbNVzclQxjLYPefJfzTVbK6TIjekApD4xQktEiZUjuR gnFg== X-Gm-Message-State: AJIora/KlcJMl+DsUptGMA3KcuzKhzht432BrKxazOXqBWpZUzO14bOa 24hYx7CUO56QEZhKLhAge9eJnW0lrORYr75jp+77+CnCbx/dnYhpTLCg2BbSfNRb/dWH0207Sj/ 2t0qGeEY2zB8YQ1cUE7hI/w== X-Received: by 2002:adf:dfc4:0:b0:21e:8f48:e345 with SMTP id q4-20020adfdfc4000000b0021e8f48e345mr2064256wrn.596.1658756266064; Mon, 25 Jul 2022 06:37:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tqBie9LnGBy31k0wVBijpkiVTXlH2LA0TmiMiKjpmK/15hpl4MHgBSWXW9clA0Cd1ISl2QbA== X-Received: by 2002:adf:dfc4:0:b0:21e:8f48:e345 with SMTP id q4-20020adfdfc4000000b0021e8f48e345mr2064247wrn.596.1658756265735; Mon, 25 Jul 2022 06:37:45 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id t8-20020a5d42c8000000b0021e84ec3ee2sm4093271wrr.114.2022.07.25.06.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 06:37:45 -0700 (PDT) From: Andrew Burgess To: Alan Modra Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] binutils-gdb/git: highlight whitespace errors in source files In-Reply-To: References: <20220719142631.1882613-1-aburgess@redhat.com> Date: Mon, 25 Jul 2022 14:37:44 +0100 Message-ID: <877d419utz.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 13:37:49 -0000 Alan Modra via Gdb-patches writes: > On Tue, Jul 19, 2022 at 03:26:31PM +0100, Andrew Burgess via Binutils wrote: >> For a long time I've had this in my ~/.gitconfig: >> >> [core] >> whitespace = space-before-tab,indent-with-non-tab,trailing-space >> >> which causes git to show me if I muck up and use spaces instead of >> tabs, or leave in trailing whitespace. I find this really useful. > > Same here. > >> I recently proposed adding something like this to the .gitattributes >> files for the GDB sub-directories (gdb, gdbsupport, and gdbserver)[1], >> however, the question was asked - couldn't this be done at the top >> level? > > I'm happy with your patch. Thanks, I've gone ahead and pushed this. Andrew