From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 50EA3385840F for ; Mon, 18 Jul 2022 17:25:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 50EA3385840F Received: by mail-il1-x129.google.com with SMTP id f15so2889159ilj.9 for ; Mon, 18 Jul 2022 10:25:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sB9WJxpzn859tN/2kopnphe/1sj8XoIBGC9Io1kpIrE=; b=ECi9ERpjArXhc+xo2KJdI51Xnb/7OCfrLxZmJVmG8rxA/0CkWpS6n5d6xMx99dfDLz HapYNXfKl64+eams37UmqLG3irO2USU2Izq+HrhNRyxCRFv2m4FZ4Jlq3c4BukPXaRQB cTPH6j967MOUylA/2gnUPh3e7TBxC2zea5f7EdnQpd4WONHE+Af/by67fZIfgwugF+NK a2HV7+/PsDalfGoJ6TvaBZZCaE/HuVDNt2KBhBh2BskzXHPl6T3Skq0zbBQoAd8GsLkC f5D3jNa9/JTjSjkI5+M09dlugQ0M5JBjlMY0RbW9EGhY4tcuu3g7aSMdLE3sFjxzcm5D qbTw== X-Gm-Message-State: AJIora/wgFyl9NCxoHdSgoTo467+jfcWoUpWrnMzu6u8C/UL4JqA4Mx2 vpceuybRN7PuOnymttAZb1yF0Mf3XN4L8A== X-Google-Smtp-Source: AGRyM1t//LVHXQzVfLJqVrCw/MDoQ2PfIw1JITOW88M7R/R+OLOybpBmPRfttYi4pcACJSwZs5TPJA== X-Received: by 2002:a05:6e02:19c5:b0:2dc:908c:ccee with SMTP id r5-20020a056e0219c500b002dc908ccceemr14297985ill.183.1658165104579; Mon, 18 Jul 2022 10:25:04 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id q6-20020a92ca46000000b002dc86fdb1besm4994556ilo.9.2022.07.18.10.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 10:25:03 -0700 (PDT) From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Add gdb.free_objfile event registry References: <20220620173622.2711270-1-tromey@adacore.com> <20220620183612.px4ct47mq36tyqfo@ubuntu.lan> X-Attribution: Tom Date: Mon, 18 Jul 2022 11:25:02 -0600 In-Reply-To: <20220620183612.px4ct47mq36tyqfo@ubuntu.lan> (Lancelot SIX's message of "Mon, 20 Jun 2022 18:36:32 +0000") Message-ID: <877d4al4ep.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 17:25:08 -0000 >> + Copyright 2010-2022 Free Software Foundation, Inc. Lancelot> Is the 2010 intentional? It looks that this file is copied from Lancelot> gdb.base/catch-load.c which is marked 2012-2022. I changed it to just 2022. >> +/* This is updated by the .exp file. */ >> +char *libname = "catch-load-so.so"; Lancelot> To be "consistent" with other files which uses this pattern, shouldn't Lancelot> the default libname reflect the test name? Something like Lancelot> py-event-load-so.so I guess. Later in the test you use Lancelot> "py-events-shlib.so" as actual libname. I updated this. >> +clean_restart $testfile >> + >> +if {![runto_main]} { >> + return >> +} >> + >> +if { [skip_python_tests] } { return } Lancelot> I guess that this skip check can be moved above (together with the Lancelot> skip_shlib_tests), so on target which skip python tests we do not bother Lancelot> compiling the test program. WDYT? Unfortunately, skip_python_tests requires that gdb already be running. I'm going to check in the updated patch now. Tom