From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id E34B93858C83 for ; Tue, 26 Apr 2022 19:28:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E34B93858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 4BBBD100474E8 for ; Tue, 26 Apr 2022 19:28:54 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id jQrlnYx1Bwm8ijQrmnZn2f; Tue, 26 Apr 2022 19:28:54 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DpSTREz+ c=1 sm=1 tr=0 ts=626847f6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=RATEnUos5ZmyyBSIQ7UA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hUVxLCRkbX84PhhK2fpsiGD8FzjntY8QIz0/JyDPdIg=; b=O47C+N2aMdHRFVln6LTEf/bCW1 7ZFn1tLjlaiVmJI7VuF9hYWnSPYFyz+m1GcoGPfEbOF3C0i06G/smqD3OTvVPFEUH5oRbBy6MiiRB b5g+aorE3K/MQGOxnRMjrGLwP; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55682 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1njQrl-001hyq-F0; Tue, 26 Apr 2022 13:28:53 -0600 From: Tom Tromey To: Lancelot SIX via Gdb-patches Cc: Lancelot SIX , lsix@lancelotsix.com Subject: Re: [PATCH] gdb: cooked_index_functions::expand_symtabs_matching: require psymtab References: <20220426141917.2887797-1-lancelot.six@amd.com> X-Attribution: Tom Date: Tue, 26 Apr 2022 13:28:52 -0600 In-Reply-To: <20220426141917.2887797-1-lancelot.six@amd.com> (Lancelot SIX via Gdb-patches's message of "Tue, 26 Apr 2022 15:19:17 +0100") Message-ID: <877d7bod8r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1njQrl-001hyq-F0 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55682 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 19:28:56 -0000 >>>>> Lancelot SIX via Gdb-patches writes: > The new indexer's expand_symtabs_matching callback does not have a call > to the objfile's require_partial_symbols, so there is not mechanism to > ensure that the psymtab is laded at this point. I wonder if this lazy loading is even worthwhile any more. Perhaps just removing SYMFILE_NO_READ entirely is the way to go. Tom