From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 2455F3857C4F for ; Fri, 11 Mar 2022 15:23:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2455F3857C4F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 7416B1005DDA6 for ; Fri, 11 Mar 2022 15:23:49 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Sh7MnCSGOQs3CSh7NnIVA9; Fri, 11 Mar 2022 15:23:49 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=d8AwdTvE c=1 sm=1 tr=0 ts=622b6985 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=N_V-M7HhHZhV9JuYZkcA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JNsyTidpSQ7fn9gv1MhRhLxY3kwJjoyQ3xnE9OlypaE=; b=bTmAIvEjc8bXkQ34UWjbM8CeNr rD+mNk/0dkhpWhZ8/W4XEPu46jr8m0Hrr2b9Clh2PzgWXA1u//R8xUUgW7qUue7I9LrulBgGvbIjY x5a5lIAGkptDJtHxK47hDTrDO; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37968 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSh7M-00230O-CE; Fri, 11 Mar 2022 08:23:48 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: tom@tromey.com, Aaron Merey , aburgess@redhat.com, lsix@lancelot.com Subject: Re: [PATCH 1/2] gdb: Add soname to build-id mapping for core files References: <871qzhvke5.fsf@tromey.com> <20220308003046.171070-1-amerey@redhat.com> X-Attribution: Tom Date: Fri, 11 Mar 2022 08:23:47 -0700 In-Reply-To: <20220308003046.171070-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Mon, 7 Mar 2022 19:30:46 -0500") Message-ID: <877d90ms1o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nSh7M-00230O-CE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37968 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 15:23:54 -0000 >>>>> Aaron Merey via Gdb-patches writes: Hi again. > + if (soname.get () != nullptr) I don't think you need the .get here. > + std::unordered_map filename_map; I suspect this code is intended to use the contents of the string as the key -- but this will actually use the pointer value as the key. If the pointer value is intended, some comment somewhere to that effect -- explaining why it's an ok approach -- would be good to have. > + if (sec->flags & SEC_LOAD > + && get_elf_backend_data (cbfd)->elf_backend_core_find_build_id > + (cbfd, (bfd_vma) sec->filepos)) The get_elf_backend_data call has to have parens around it according to GNU / gdb style. > + /* Read the soname from the string table. */ > + gdb::byte_vector dynstr_buf; > + if (!gdb_bfd_get_full_section_contents (abfd.get (), dynstr, &dynstr_buf)) > + return {}; > + > + return make_unique_xstrdup ((char *) dynstr_buf.data () + idx); What if the data isn't \0-terminated? Maybe some size checking (not sure if needed) and make_unique_xstrndup would be safer. Tom