From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Print MI prompt on interrupted command
Date: Fri, 25 Feb 2022 06:59:45 -0700 [thread overview]
Message-ID: <877d9joxm6.fsf@tromey.com> (raw)
In-Reply-To: <20220225134018.GV2571@redhat.com> (Andrew Burgess's message of "Fri, 25 Feb 2022 13:40:18 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> I can't speak to whether this would break existing clients or not, for
Andrew> me, I'd be happy to have this go in, and see how things go.
Thanks for looking at this.
FWIW, yesterday I was looking through bugzilla and found out that this
was reported as a bug a few years ago:
https://sourceware.org/bugzilla/show_bug.cgi?id=23820
Andrew> On the code change itself, again, I'm happy with what you have, it
Andrew> matches the existing code. But, I do find the existing pattern rather
Andrew> odd:
[...]
Yeah, me too.
I managed to convince myself that checking the other UIs isn't needed.
At the same time, it seems like the sort of code that should be
direct, as opposed to indirectly calling via an observer.
Andrew> But, honestly, I don't think I'd bother right now.
Alright. I'm going to update the commit message and push it in.
Tom
prev parent reply other threads:[~2022-02-25 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 17:32 Tom Tromey
2022-01-26 18:48 ` Tom Tromey
2022-01-31 19:33 ` Tom Tromey
2022-02-25 13:40 ` Andrew Burgess
2022-02-25 13:59 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d9joxm6.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).