From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by sourceware.org (Postfix) with ESMTPS id 8F9383858D39 for ; Tue, 19 Oct 2021 19:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F9383858D39 Received: by mail-io1-xd2a.google.com with SMTP id o184so9715888iof.6 for ; Tue, 19 Oct 2021 12:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qGdmBsayuSUjLqM5/Ad4+ASt5UDYhB/u3R03zJ+xK4M=; b=c8EEMNQnJj5ENPwfdcKnTdjFrgeHbp79Lv2+rg1MpeGsXF6RxY0P3tLm+0j+v0drFi w7gIYZviPmjGkr/R+ivaHdApqHt1uUD0ztmHk2KQGNWN1tMEAsF1dzkdHK0TTIL0VCXg YyBQJl0SYynUonjLb09yyXdEFhhIQfz5vi5IWbf4sivurEORWsAnPZMxJTIaukCGRHfg iQ01S26V3LtZM4MirFuYAsWVWl0iCNjR844P1x+LRAGbPAHh6DeJ6JXhJL/BrRonOakP 5jMIUsP4Q3UvzevC8QHx43ZnhtQGvc1k2ihH1jnom/KYwO+tiGnZeuHVPFfenbXCUh3h ubwQ== X-Gm-Message-State: AOAM533FJn9UlYlhUqI/f71LXSISVoquShv95kM2Kk6pIzeCVIR1xTEE WWKHNk2nClUuwe8TS102AkVBkKhKz7ajHw== X-Google-Smtp-Source: ABdhPJz5T9zZjHf0DipcxqsDdk01XaqJHe6BoUU/oGFFTAVreD6gdrJwdGDJ5QWo3Nqcc6ugFPvoKw== X-Received: by 2002:a6b:148:: with SMTP id 69mr19626435iob.54.1634671590118; Tue, 19 Oct 2021 12:26:30 -0700 (PDT) Received: from murgatroyd (174-16-0-219.hlrn.qwest.net. [174.16.0.219]) by smtp.gmail.com with ESMTPSA id 81sm8624217iou.21.2021.10.19.12.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 12:26:29 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Fix Rust lex selftest when using libiconv References: <20210930185549.579369-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 19 Oct 2021 13:26:28 -0600 In-Reply-To: <20210930185549.579369-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 30 Sep 2021 12:55:49 -0600") Message-ID: <877de8x1cr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 19:26:32 -0000 >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> The Rust lex selftest fails on our Windows build. I tracked this down Tom> to a use of UTF-32 as a parameter to convert_between_encodings. Here, Tom> iconv_open succeeds, but the actual conversion of a tab character Tom> fails with EILSEQ. I suspect that "UTF-32" is being interpreted as Tom> big-endian, as changing the call to use "UTF-32LE" makes it work. Tom> This patch implements this fix. I'm checking this in. Tom