From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Replace exception_print_same with operator!=
Date: Fri, 30 Jul 2021 08:37:33 -0600 [thread overview]
Message-ID: <877dh798b6.fsf@tromey.com> (raw)
In-Reply-To: <c358cede-31c5-35a0-0d46-4bfb86a21764@polymtl.ca> (Simon Marchi's message of "Thu, 29 Jul 2021 22:13:46 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> On 2021-07-29 7:13 p.m., Tom Tromey wrote:
>> I noticed that exception_print_same is only used in a single spot, and
>> it seemed to be better as an operator!= method attached to
>> gdb_exception.
Simon> I think the declaration should be removed as well, otherwise LGTM.
Oops, I thought I did this.
I'll be sure to do it before pushing.
Tom
prev parent reply other threads:[~2021-07-30 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 23:13 Tom Tromey
2021-07-30 2:13 ` Simon Marchi
2021-07-30 14:37 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dh798b6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).