From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/5] gdb/python: handle saving user registers in a frame unwinder
Date: Mon, 07 Jun 2021 08:50:56 -0600 [thread overview]
Message-ID: <877dj5n2y7.fsf@tromey.com> (raw)
In-Reply-To: <c8d1850c5fc83e02acf404c71ea6d28940489fec.1622321523.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sat, 29 May 2021 21:57:10 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> So, in this patch I propose that in the unwinder code, when
Andrew> add_saved_register is called, if it is passed a
Andrew> user-register (i.e. non-cooked) then we first fetch the register,
Andrew> extract the real register number from the value's location, and use
Andrew> that new register number when handling the add_saved_register call.
Andrew> If either the value location that we get for the user-register is not
Andrew> a cooked register then we can throw a 'Bad register' error back to the
Andrew> Python code, but in most cases this will not happen.
I was worried that requesting this would require unwinding the register,
which is what is currently being done. But I suppose the idea is that
the value is normally lazy, so it isn't actually unwound?
Tom
next prev parent reply other threads:[~2021-06-07 14:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 20:57 [PATCH 0/5] Fix for an assertion when unwinding with inline frames Andrew Burgess
2021-05-29 20:57 ` [PATCH 1/5] gdb/python: handle saving user registers in a frame unwinder Andrew Burgess
2021-06-07 14:50 ` Tom Tromey [this message]
2021-06-07 16:10 ` Andrew Burgess
2021-06-07 20:38 ` Tom Tromey
2021-06-07 17:07 ` Lancelot SIX
2021-06-07 17:20 ` Simon Marchi
2021-06-07 18:01 ` Lancelot SIX
2021-06-07 18:09 ` Simon Marchi
2021-06-07 20:12 ` Andrew Burgess
2021-06-21 19:41 ` Andrew Burgess
2021-05-29 20:57 ` [PATCH 2/5] gdb/python: move PyLong_From* calls into py-utils.c Andrew Burgess
2021-06-07 14:53 ` Tom Tromey
2021-06-21 19:42 ` Andrew Burgess
2021-05-29 20:57 ` [PATCH 3/5] gdb/python: add PendingFrame.level and Frame.level methods Andrew Burgess
2021-05-30 5:55 ` Eli Zaretskii
2021-05-30 18:34 ` Andrew Burgess
2021-05-30 18:54 ` Eli Zaretskii
2021-06-07 14:57 ` Tom Tromey
2021-06-21 19:42 ` Andrew Burgess
2021-05-29 20:57 ` [PATCH 4/5] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-05-29 20:57 ` [PATCH 5/5] gdb: remove VALUE_FRAME_ID Andrew Burgess
2021-06-21 19:46 ` [PATCHv2 0/2] Fix for an assertion when unwinding with inline frames Andrew Burgess
2021-06-21 19:46 ` [PATCHv2 1/2] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-07-05 11:39 ` Pedro Alves
2021-07-05 14:14 ` Simon Marchi
2021-06-21 19:46 ` [PATCHv2 2/2] gdb: remove VALUE_FRAME_ID Andrew Burgess
2021-06-29 17:53 ` Simon Marchi
2021-06-30 15:18 ` Andrew Burgess
2021-07-05 14:22 ` Simon Marchi
2021-07-20 9:10 ` [PATCHv3 0/2] Fix for an assertion when unwinding with inline frames Andrew Burgess
2021-07-20 9:10 ` [PATCHv3 1/2] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-07-20 9:10 ` [PATCHv3 2/2] gdb: remove VALUE_FRAME_ID Andrew Burgess
2021-07-20 21:59 ` [PATCHv3 0/2] Fix for an assertion when unwinding with inline frames Simon Marchi
2021-07-26 11:11 ` Andrew Burgess
2021-07-26 13:57 ` Simon Marchi
2021-07-27 10:06 ` Andrew Burgess
2021-07-27 10:10 ` [PATCHv4] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-08-09 15:41 ` [PATCHv5] " Andrew Burgess
2021-08-23 9:41 ` Andrew Burgess
2021-08-23 10:26 ` Pedro Alves
2021-08-23 12:31 ` Andrew Burgess
2021-09-20 10:04 ` Andrew Burgess
2021-09-20 12:24 ` Pedro Alves
2021-09-21 13:52 ` Andrew Burgess
2021-09-21 13:54 ` [PATCHv6] " Andrew Burgess
2021-09-22 14:14 ` Simon Marchi
2021-09-22 16:46 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dj5n2y7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).