From: Tom Tromey <tom@tromey.com>
To: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb:Add new 'print binary-groups' feature
Date: Thu, 03 Dec 2020 13:13:48 -0700 [thread overview]
Message-ID: <877dpybqbn.fsf@tromey.com> (raw)
In-Reply-To: <MEAPR01MB36723B0E1C1AD138C9DD387DDDF60@MEAPR01MB3672.ausprd01.prod.outlook.com> (Enze Li via Gdb-patches's message of "Sun, 29 Nov 2020 21:00:05 +0800")
>>>>> ">" == Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:
>> Make an introduction of a new print setting that can be set by
>> 'set print binary-groups [on|off]'. The default value is OFF, and
>> it would be changed by users manually.
Seems like a reasonable feature to me.
>> gdb/doc/ChangeLog:
>> * gdb.texinfo: Document 'set/show print binary-groups'.
Eli will have to approve the documentation change.
>> + if (options->binary_group_print && seen_a_one && i%4 == 0)
The gdb style requires spaces around the "%" operator.
>> + if (options->binary_group_print && seen_a_one && i%4 == 0)
Here too.
The rest looks good to me. Thank you for doing this.
I didn't look - do you have a copyright assignment in place with the
FSF? If not, contact me off-list so we can get started on this.
Tom
next prev parent reply other threads:[~2020-12-03 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 13:00 Enze Li
2020-12-03 20:13 ` Tom Tromey [this message]
2020-12-06 4:53 ` Enze Li
2020-12-03 20:33 ` Eli Zaretskii
2020-12-06 5:53 ` Enze Li
2020-12-04 15:44 ` Pedro Alves
2020-12-06 4:55 ` Enze Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dpybqbn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).