From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 0/4] Move dyn prop functions to be methods of struct type
Date: Thu, 07 May 2020 07:59:47 -0600 [thread overview]
Message-ID: <877dxnzvzg.fsf@tromey.com> (raw)
In-Reply-To: <20200430181753.1093-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 30 Apr 2020 14:17:49 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> I'd like to start cleaning up gdbtypes.h. In particular, move some functions
Simon> and some of the TYPE_* macros to be methods of `struct type`. To test the
Simon> waters, I started with the dynamic property stuff, which is quite isolated.
Looks good to me. I support this project in general; I don't think
macros of this form really add value. There's been a time or two in the
past where we were able to use the macros to change the representation a
little -- but that's even easier with methods.
thanks,
Tom
next prev parent reply other threads:[~2020-05-07 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 18:17 Simon Marchi
2020-04-30 18:17 ` [PATCH 1/4] gdb: make get_dyn_prop a method " Simon Marchi
2020-04-30 18:17 ` [PATCH 2/4] gdb: make add_dyn_prop " Simon Marchi
2020-04-30 18:17 ` [PATCH 3/4] gdb: make remove_dyn_prop " Simon Marchi
2020-04-30 18:17 ` [PATCH 4/4] gdb: remove TYPE_DYN_PROP_LIST macro Simon Marchi
2020-05-07 13:58 ` Tom Tromey
2020-05-07 14:15 ` Simon Marchi
2020-05-07 13:59 ` Tom Tromey [this message]
2020-05-07 14:07 ` [PATCH 0/4] Move dyn prop functions to be methods of struct type Simon Marchi
2020-05-07 15:34 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dxnzvzg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).