From: Tom Tromey <tom@tromey.com>
To: Kamil Rytarowski <n54@gmx.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat
Date: Thu, 16 Apr 2020 14:07:15 -0600 [thread overview]
Message-ID: <877dyf19fw.fsf@tromey.com> (raw)
In-Reply-To: <20200416165859.10785-1-n54@gmx.com> (Kamil Rytarowski's message of "Thu, 16 Apr 2020 18:58:59 +0200")
>>>>> ">" == Kamil Rytarowski <n54@gmx.com> writes:
>> All major BSDs implement PT_GET_PROCESS_STATE, but they differ in
>> details and want to implement follow-fork functionality differently.
>> gdb/ChangeLog:
>> * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
>> (remove_fork_catchpoint, post_startup_inferior)
>> (post_attach): Move...
I guess these aren't used on Linux, but what about rs6000-nat.c? Those
are the only non-BSD users of inf_ptrace_target that I can see.
I'm not a big fan of the current code, because makes methods conditional
on this define. It would be better I guess to have an intermediate
subclass for this situation. That would make it clear what code does or
does not rely on this.
You don't have to do that, but I don't think we can put this in without
knowing about the rs6000-nat case.
Tom
next prev parent reply other threads:[~2020-04-16 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 16:58 Kamil Rytarowski
2020-04-16 20:07 ` Tom Tromey [this message]
2020-04-16 21:32 ` Kamil Rytarowski
2020-04-20 10:30 ` Kamil Rytarowski
2020-04-24 9:15 ` Kamil Rytarowski
2020-04-24 15:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dyf19fw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).