From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.156]) by sourceware.org (Postfix) with ESMTPS id 64D2D385BF83 for ; Mon, 6 Apr 2020 20:27:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64D2D385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id F2D27B18B for ; Mon, 6 Apr 2020 15:27:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id LYKxjlj5LXVkQLYKxjza7K; Mon, 06 Apr 2020 15:27:15 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WIdmxQV9IrgIKqZW8luQjobHcWk3FpdWgQwKYMJHu1Y=; b=LEw9UZhGPyMw5fQ4vJqgkc+L/k ysu0ew8YixxSjQH6CXXfqrfEv419tysfwDMvbjSU38zGm2NBTPUKisaBmONj287qgsqmXtbB59DHj xkFCuKMYXn+NbQZ0XFBa07+1d; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:59116 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jLYKx-002Lia-Lf; Mon, 06 Apr 2020 14:27:15 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Don't corrupt completions hash when expanding the hash table References: <8a0ef7f9-1188-6a76-955c-dc7e8ee9b00e@linaro.org> <20200404153729.1547002-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Mon, 06 Apr 2020 14:27:14 -0600 In-Reply-To: <20200404153729.1547002-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sat, 4 Apr 2020 16:37:29 +0100") Message-ID: <877dysbbrx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jLYKx-002Lia-Lf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (murgatroyd) [174.16.110.145]:59116 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 20:27:17 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> gdb/ChangeLog: Andrew> * completer.c (class completion_tracker::completion_hash_entry) Andrew> : New member function. Andrew> (completion_tracker::discard_completions): New callback to hash a Andrew> completion_hash_entry, pass this to htab_create_alloc. Andrew> gdb/testsuite/ChangeLog: Andrew> * gdb.base/many-completions.exp: New file. Thanks. This looks good. Tom