From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114170 invoked by alias); 14 Jan 2020 23:18:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114162 invoked by uid 89); 14 Jan 2020 23:18:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2020 23:18:29 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 478E6400CA736 for ; Tue, 14 Jan 2020 17:16:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id rVQHihXKpNwe7rVQHiIjn1; Tue, 14 Jan 2020 17:16:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GW0/Wu/d6BHs+MrxMaymg2UGeklt/YRwgpOYbENMAko=; b=KpG4snv26rm0QXP8JSIt6DyGpG M1pcfA/SvBMcRdhXvIIm1av4Y7txvqHr91xazGDR4b11uGSncOr+QrVWjTM8y+s6/1xkkFoctaxNk 7EC5Jo4RQgnH6dMMSc86ocSts; Received: from 50-194-130-62-static.hfc.comcastbusiness.net ([50.194.130.62]:49812 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1irVQH-003k0S-0H; Tue, 14 Jan 2020 16:16:33 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level References: <20200109005807.7314-1-tom@tromey.com> <878smeexqf.fsf@tromey.com> <11a3ff10-71aa-7af0-66d1-5cdf6dfef3c2@simark.ca> Date: Tue, 14 Jan 2020 23:25:00 -0000 In-Reply-To: <11a3ff10-71aa-7af0-66d1-5cdf6dfef3c2@simark.ca> (Simon Marchi's message of "Sat, 11 Jan 2020 21:19:08 -0500") Message-ID: <877e1t1ved.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00394.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> The indentation in common.m4 looks off, starting with: Simon> AC_CACHE_CHECK([for sigsetjmp], gdb_cv_func_sigsetjmp Simon> Starting from this line until the end, I think it should be indented by Simon> two columns. It's already wrong today, but what you added also has wrong Simon> indentation, making it hard to understand that it's all under `GDB_AC_COMMON`. Simon> Could you fix that? I don't really mind if it's a patch before or after this Simon> series. I will send and check in a patch for that shortly. Simon> I see that GDB_AC_PTRACE is called in all three configure.ac files. Should it Simon> be put in GDB_AC_COMMON? We don't have a good way to include ptrace.m4 from common.m4. Maybe the call could be moved there but the user still has to know to include ptrace.m4 somewhere. Tom