From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Replace xmalloc/xfree with vector in jit.c
Date: Thu, 12 Dec 2019 19:00:00 -0000 [thread overview]
Message-ID: <877e315py7.fsf@tromey.com> (raw)
In-Reply-To: <20191211063732.1043487-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Wed, 11 Dec 2019 01:37:31 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> I'm currently studying that code and noticed this manual memory
Simon> management, which could easily be replaced with a vector, so here it is.
Simon> gdb/ChangeLog:
Simon> * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
Simon> gdb::byte_vector.
Thanks, this looks good to me.
Tom
next prev parent reply other threads:[~2019-12-12 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 6:38 Simon Marchi
2019-12-11 6:38 ` [PATCH 2/2] Fix indentation " Simon Marchi
2019-12-12 19:01 ` Tom Tromey
2019-12-12 19:54 ` Simon Marchi
2019-12-13 9:11 ` Strasuns, Mihails
2019-12-13 9:18 ` Eli Zaretskii
2019-12-13 14:43 ` Pedro Alves
2019-12-13 15:14 ` Simon Marchi
2019-12-12 19:00 ` Tom Tromey [this message]
2019-12-12 19:55 ` [PATCH 1/2] Replace xmalloc/xfree with vector " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e315py7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).