From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH] Include xml-support.h to get a variable declaration
Date: Wed, 09 Oct 2019 17:47:00 -0000 [thread overview]
Message-ID: <877e5derqg.fsf@tromey.com> (raw)
In-Reply-To: <20191007190631.47743-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 7 Oct 2019 14:06:31 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> Instead of declaring xml_builtin as an extern variable
Christian> in the .c file.
Christian> gdb/gdbserver/ChangeLog:
Christian> 2019-10-07 Christian Biesinger <cbiesinger@google.com>
Christian> * server.c (get_features_xml): Remove declaration of xml_builtin
Christian> in favor of including xml-support.h.
I don't think we want to include xml-support.h in gdbserver.
Maybe the xml_builtin can be declared somewhere else instead.
It's only defined in generated files according to the comment.
Tom
next prev parent reply other threads:[~2019-10-09 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 19:06 Christian Biesinger via gdb-patches
2019-10-09 17:47 ` Tom Tromey [this message]
2019-10-10 2:44 ` [PATCH v2] Create xml-builtin.h to declare xml_builtins cbiesinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e5derqg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).