From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66332 invoked by alias); 9 Oct 2019 17:47:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66324 invoked by uid 89); 9 Oct 2019 17:47:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:675, UD:server.c, serverc, server.c X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2019 17:47:05 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 17AC6B2BB5 for ; Wed, 9 Oct 2019 12:47:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IG3EiaVUvHunhIG3EiGIKE; Wed, 09 Oct 2019 12:47:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xUa6MKCqQAUuasz0jGUs1bbI9oo8ycAVRtngiMZz9zA=; b=CIhM59iZQiNgrKDEKluGs5C2Bm y4UnEdZ2f8yOZYTGSgxvRAEQXol3Qu6orHjTTEgKCKOui/BzdOW8iWSshsWbEBSZNEg6vOLNXY/Vr IAEvxF0OlP6yc4F3Ta+RWcJgQ; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:57958 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iIG3D-002IHa-Sk; Wed, 09 Oct 2019 11:47:03 -0600 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Include xml-support.h to get a variable declaration References: <20191007190631.47743-1-cbiesinger@google.com> Date: Wed, 09 Oct 2019 17:47:00 -0000 In-Reply-To: <20191007190631.47743-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 7 Oct 2019 14:06:31 -0500") Message-ID: <877e5derqg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00253.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> Instead of declaring xml_builtin as an extern variable Christian> in the .c file. Christian> gdb/gdbserver/ChangeLog: Christian> 2019-10-07 Christian Biesinger Christian> * server.c (get_features_xml): Remove declaration of xml_builtin Christian> in favor of including xml-support.h. I don't think we want to include xml-support.h in gdbserver. Maybe the xml_builtin can be declared somewhere else instead. It's only defined in generated files according to the comment. Tom