From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120547 invoked by alias); 29 Nov 2018 18:31:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119204 invoked by uid 89); 29 Nov 2018 18:31:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:794 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 18:31:18 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 8FC6416276 for ; Thu, 29 Nov 2018 12:31:17 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SR5pgsRHVSjJASR5pgFb3G; Thu, 29 Nov 2018 12:31:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UmkYeFrLcKxNQMwJFQkzw91TyTWNVFhtKolhVB0TBuA=; b=lU5YEK2BOnwibr+aXJlPL7disM 7Aojd6j7gyaJogZ7GUiZVSjRqFJP5eB9sGBSRt4V/aQW8YWRw2LMtoYvMblgiCnbTN+kwF02XsFv7 D3nudCanM0YgCkkQBYYqGVcAU; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:33014 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSR5p-0019sy-B2; Thu, 29 Nov 2018 12:31:17 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Convert default_child_has_foo functions to process_stratum_target methods References: <20181127202247.7646-1-palves@redhat.com> <20181127202247.7646-4-palves@redhat.com> Date: Thu, 29 Nov 2018 18:31:00 -0000 In-Reply-To: <20181127202247.7646-4-palves@redhat.com> (Pedro Alves's message of "Tue, 27 Nov 2018 20:22:47 +0000") Message-ID: <877egvburv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00544.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> +bool Pedro> +process_stratum_target::has_all_memory () Pedro> +{ Pedro> + /* If no inferior selected, then we can't read memory here. */ Pedro> + if (inferior_ptid == null_ptid) Pedro> + return false; Pedro> + Pedro> + return true; I don't really care too much but I was wondering why not just return inferior_ptid != null_ptid; Pedro> +bool Pedro> +process_stratum_target::has_execution (ptid_t the_ptid) Pedro> +{ Pedro> + /* If there's no thread selected, then we can't make it run through Pedro> + hoops. */ Pedro> + if (the_ptid == null_ptid) Pedro> + return 0; Pedro> + Pedro> + return 1; This one should use true/false. Tom