From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1715 invoked by alias); 17 Sep 2018 21:22:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1706 invoked by uid 89); 17 Sep 2018 21:22:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 21:22:44 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id A7A772FAF for ; Mon, 17 Sep 2018 16:22:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 20yggcynpkBj620yggn5pv; Mon, 17 Sep 2018 16:22:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KQWR03g4/C2LQTB3Y3rfxP5ZjPqvstZbvzGbNkCxPyQ=; b=xe/8ZTXxhVNpegPYpIUWJYBvSE dFZ++0hsvB/NsYQofl82vj2JKiKTvgnSiP12jlUg/YwC3EBQFU9wJEejI0FkmdN0dErYZZkrzN67d Akj2xa6RM+ijREKUH5piBl4x+; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:49156 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g20yg-002LwE-CG; Mon, 17 Sep 2018 16:22:42 -0500 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode References: <20180916184502.19617-1-tom@tromey.com> <20180916184502.19617-3-tom@tromey.com> <20180917181905.GD19172@adacore.com> <87va74ugpf.fsf@tromey.com> <87r2hrnbox.fsf@tromey.com> <20180917212135.GH19172@adacore.com> Date: Mon, 17 Sep 2018 21:22:00 -0000 In-Reply-To: <20180917212135.GH19172@adacore.com> (Joel Brobecker's message of "Mon, 17 Sep 2018 14:21:35 -0700") Message-ID: <877ejjvmxq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00607.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> >>>>> "Joel" == Joel Brobecker writes: Joel> Are we missing a '$' before tentative_python_cflags in the string, Joel> by any chance? >> Tom> Yes, oops. I wonder how that slipped through. >> >> Obviously I did not test in release mode. >> I've fixed the bug and tried it both ways. Joel> Thanks Tom. Other than this comment, I had no other comment so, Joel> now that it is fixed and tested, I think you can push. I'd already done it since it seemed pretty clear. Tom